西风逍遥游
31880f0021
`examples/<name>/` was a tested surface in name only. The source-quality job had no examples check at all, and scripts/smoke_examples.sh accepted any process that had not printed one of its error markers: a project that died during startup, exited after a single frame, or crashed without a marker was reported as PASS. Nothing stopped a malformed or unregistered example from reaching dev, which is how 14 examples arrived without READMEs and 20 were never registered in the overview table. Source side - scripts/check_examples.py classifies every directory under examples/ as either runnable (main.nut plus a config.nut that assigns the engine `config` table) or as a reviewed non-runnable sample listed in NON_RUNNABLE_EXAMPLES with a reason. Both kinds must own a README.md and appear in examples/README.md. Stale exemptions and overview links to missing directories fail as well. - `make check/examples` and a new source-quality CI step run the gate. - scripts/tests/test_check_examples.py covers it and pins each failure mode against fixtures. Runtime side - scripts/smoke_examples.sh now enforces liveness, not just marker absence: every runnable example must still be running after MIN_RUN_SECONDS (default 2s; CI passes 2s), and a process that dies inside that window fails whatever its exit code. A clean self-exit after the window passes with an explicit note instead of being silently accepted as a pass. - The Linux CI step sets MIN_RUN_SECONDS=2 and keeps RUN_SECONDS=6, so the job's wall clock is unchanged (13.7 min of its 20 min budget on dev). Windows / GBK - scripts/utf8_stdio.py re-encodes stdout/stderr as UTF-8 and every scripts/*.py program calls it as the first statement of its __main__ block. On a Chinese Windows a redirected stream falls back to the ANSI code page (cp936), and printing a character that code page cannot encode (arrows, superscripts, bullet separators, emoji - all common in this repository) raised UnicodeEncodeError and turned a checker into a traceback. - The mirror image is input: read_text() without encoding= decoded UTF-8 repository text as cp936 and raised UnicodeDecodeError. - scripts/tests/test_utf8_stdio.py enforces both conventions for every script and test module; text file I/O and child-process decoding now pass encoding="utf-8" explicitly. - Unit-test invocations run with `python3 -X utf8` so the runner's own output never follows the host code page. Violations the new gates found on top of dev, fixed here: 14 examples shipped without a README (fluid3d, mesh-impact-lab, mesh-modifier-lab, spline-tube-lab on the earlier dev tip, plus pcg-depth-of-field, pcg-detail-overwrite, pcg-layer-culling, pcg-location-system, pcg-runtime-orchestration, pcg-scene-player-culling, pcg-snow-wind, pcg-thunder-strike, pcg-ui-scaler and pcg-underwater added by #397), 20 were missing from the overview table (those 14 plus archspace-editor, geometry-stroke-lab, interior-mapping, layered-animation, triplanar-decal, terrain-stamping), and scripts/export_meshret_onnx.py had no UTF-8 stdio guard. Verified locally: `python -m ruff check scripts` (All checks passed); scripts/check_test_manifest.py; scripts/check_quality_metadata.py; scripts/check_architecture_contracts.py --base HEAD; scripts/check_nodiscard.py; `make -n check/examples`; scripts/check_examples.py (125 examples: 118 runnable, 7 reviewed non-runnable); and `python -X utf8 -m unittest discover -s scripts/tests -p "test_*.py"` (155 tests, OK). The runtime half of the contract needs a Linux headless build, so it is verified by the CI examples smoke step rather than locally.
77 lines
2.7 KiB
Python
77 lines
2.7 KiB
Python
#!/usr/bin/env python3
|
|
"""Validate ownership and budget metadata for the binding-gap allowlist.
|
|
|
|
This is deliberately a separate gate from check_bindings.py. It reads the
|
|
existing plain-text gap list and its JSON sidecar; it never rewrites either
|
|
file and never invokes check_bindings.py --write-gaps.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import datetime as dt
|
|
import json
|
|
import re
|
|
import sys
|
|
from pathlib import Path
|
|
import utf8_stdio
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
GAPS = ROOT / "scripts" / "check_bindings_gaps.txt"
|
|
METADATA = ROOT / "scripts" / "check_bindings_gaps.metadata.json"
|
|
ENTRY = re.compile(r"^[A-Za-z0-9_.-]+:[A-Za-z0-9_.-]+$")
|
|
REQUIRED = ("owner", "issue", "reason", "expiry")
|
|
|
|
|
|
def main() -> int:
|
|
try:
|
|
metadata = json.loads(METADATA.read_text(encoding="utf-8"))
|
|
except (OSError, json.JSONDecodeError) as error:
|
|
print(f"FAIL binding gap metadata cannot be read: {error}")
|
|
return 1
|
|
|
|
entries = [
|
|
line.strip()
|
|
for line in GAPS.read_text(encoding="utf-8").splitlines()
|
|
if line.strip() and not line.lstrip().startswith("#")
|
|
]
|
|
failures: list[str] = []
|
|
if any(not ENTRY.fullmatch(entry) for entry in entries):
|
|
failures.append("gap entries must use module:binding format")
|
|
if len(entries) != len(set(entries)):
|
|
failures.append("gap entries must be unique")
|
|
|
|
default = metadata.get("default", {})
|
|
for key in REQUIRED:
|
|
if not isinstance(default.get(key), str) or not default[key].strip():
|
|
failures.append(f"default metadata is missing {key}")
|
|
expiry = default.get("expiry", "")
|
|
try:
|
|
if dt.date.fromisoformat(expiry) <= dt.date.today():
|
|
failures.append("default metadata expiry must be in the future")
|
|
except ValueError:
|
|
failures.append("default metadata expiry must be YYYY-MM-DD")
|
|
|
|
baseline = metadata.get("baselineCount")
|
|
if not isinstance(baseline, int) or baseline < 0:
|
|
failures.append("baselineCount must be a non-negative integer")
|
|
elif len(entries) > baseline:
|
|
failures.append(f"binding-gap allowlist grew from baseline {baseline} to {len(entries)}")
|
|
|
|
policy = metadata.get("policy", {})
|
|
if policy.get("allowNetGrowth") is not False:
|
|
failures.append("policy.allowNetGrowth must remain false")
|
|
if policy.get("metadataFileIsReadOnly") is not True:
|
|
failures.append("policy.metadataFileIsReadOnly must remain true")
|
|
|
|
if failures:
|
|
for failure in failures:
|
|
print(f"FAIL {failure}")
|
|
return 1
|
|
print(f"binding gap metadata OK: {len(entries)} entries, baseline {baseline}, no net growth")
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
utf8_stdio.enable_utf8_stdio()
|
|
sys.exit(main())
|