`examples/<name>/` was a tested surface in name only. The source-quality job had no examples check at all, and scripts/smoke_examples.sh accepted any process that had not printed one of its error markers: a project that died during startup, exited after a single frame, or crashed without a marker was reported as PASS. Nothing stopped a malformed or unregistered example from reaching dev, which is how 14 examples arrived without READMEs and 20 were never registered in the overview table. Source side - scripts/check_examples.py classifies every directory under examples/ as either runnable (main.nut plus a config.nut that assigns the engine `config` table) or as a reviewed non-runnable sample listed in NON_RUNNABLE_EXAMPLES with a reason. Both kinds must own a README.md and appear in examples/README.md. Stale exemptions and overview links to missing directories fail as well. - `make check/examples` and a new source-quality CI step run the gate. - scripts/tests/test_check_examples.py covers it and pins each failure mode against fixtures. Runtime side - scripts/smoke_examples.sh now enforces liveness, not just marker absence: every runnable example must still be running after MIN_RUN_SECONDS (default 2s; CI passes 2s), and a process that dies inside that window fails whatever its exit code. A clean self-exit after the window passes with an explicit note instead of being silently accepted as a pass. - The Linux CI step sets MIN_RUN_SECONDS=2 and keeps RUN_SECONDS=6, so the job's wall clock is unchanged (13.7 min of its 20 min budget on dev). Windows / GBK - scripts/utf8_stdio.py re-encodes stdout/stderr as UTF-8 and every scripts/*.py program calls it as the first statement of its __main__ block. On a Chinese Windows a redirected stream falls back to the ANSI code page (cp936), and printing a character that code page cannot encode (arrows, superscripts, bullet separators, emoji - all common in this repository) raised UnicodeEncodeError and turned a checker into a traceback. - The mirror image is input: read_text() without encoding= decoded UTF-8 repository text as cp936 and raised UnicodeDecodeError. - scripts/tests/test_utf8_stdio.py enforces both conventions for every script and test module; text file I/O and child-process decoding now pass encoding="utf-8" explicitly. - Unit-test invocations run with `python3 -X utf8` so the runner's own output never follows the host code page. Violations the new gates found on top of dev, fixed here: 14 examples shipped without a README (fluid3d, mesh-impact-lab, mesh-modifier-lab, spline-tube-lab on the earlier dev tip, plus pcg-depth-of-field, pcg-detail-overwrite, pcg-layer-culling, pcg-location-system, pcg-runtime-orchestration, pcg-scene-player-culling, pcg-snow-wind, pcg-thunder-strike, pcg-ui-scaler and pcg-underwater added by #397), 20 were missing from the overview table (those 14 plus archspace-editor, geometry-stroke-lab, interior-mapping, layered-animation, triplanar-decal, terrain-stamping), and scripts/export_meshret_onnx.py had no UTF-8 stdio guard. Verified locally: `python -m ruff check scripts` (All checks passed); scripts/check_test_manifest.py; scripts/check_quality_metadata.py; scripts/check_architecture_contracts.py --base HEAD; scripts/check_nodiscard.py; `make -n check/examples`; scripts/check_examples.py (125 examples: 118 runnable, 7 reviewed non-runnable); and `python -X utf8 -m unittest discover -s scripts/tests -p "test_*.py"` (155 tests, OK). The runtime half of the contract needs a Linux headless build, so it is verified by the CI examples smoke step rather than locally.
79 lines
3.1 KiB
Python
79 lines
3.1 KiB
Python
#!/usr/bin/env python3
|
|
"""Make a repository script's text streams UTF-8 on every host.
|
|
|
|
CI runs these scripts on Linux, where ``sys.stdout`` and ``sys.stderr`` are
|
|
UTF-8. A Windows host is not automatically UTF-8: as soon as the output is
|
|
redirected -- an IDE terminal, ``> log.txt``, ``| tee``, or a tool capturing the
|
|
command -- Python encodes text with the ANSI code page from the locale, which is
|
|
cp936 (GBK) on a Chinese Windows. Printing a diagnostic containing a character
|
|
that code page cannot represent then raises ``UnicodeEncodeError`` and turns a
|
|
checker into a traceback.
|
|
|
|
That is reachable, not theoretical: this repository is full of characters cp936
|
|
cannot encode (``↔``, ``²``, ``³``, ``⇒``, ``•``, emoji), and checkers print text
|
|
they read back out of the tree -- for example ``scripts/check_examples.py
|
|
--print-missing-rows`` prints each example README's own title.
|
|
|
|
Call :func:`enable_utf8_stdio` once from a program's entry point, never at import
|
|
time, so importing a script module stays free of side effects::
|
|
|
|
import utf8_stdio
|
|
|
|
...
|
|
|
|
if __name__ == "__main__":
|
|
utf8_stdio.enable_utf8_stdio()
|
|
raise SystemExit(main())
|
|
|
|
``scripts/tests/test_utf8_stdio.py`` enforces that convention for every program
|
|
under ``scripts/``, and pins the failure this module exists to remove.
|
|
|
|
Scope: this normalises the process's *text streams*. It cannot change the
|
|
locale-derived default that ``open()`` and ``subprocess`` use for *other* text,
|
|
so code that decodes a child process or writes a data file must still pass
|
|
``encoding="utf-8"`` explicitly; the Makefile/CI paths that run unit tests use
|
|
``python3 -X utf8`` so runner-generated text is UTF-8 too.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from typing import TextIO
|
|
|
|
# Codec error handler used by default: unlike "strict" it never raises, so a
|
|
# stray surrogate or an unforeseen character cannot abort a checker. Python
|
|
# itself uses backslashreplace for the default sys.stderr policy.
|
|
DEFAULT_ERRORS = "backslashreplace"
|
|
|
|
|
|
def _reconfigure(stream: TextIO, errors: str) -> bool:
|
|
"""Re-encode one stream as UTF-8; return True when it was reconfigured.
|
|
|
|
Streams that cannot be reconfigured are left untouched rather than treated
|
|
as an error: a test may have replaced ``sys.stdout`` with a plain object,
|
|
and a detached or already-closed stream must not turn into a second
|
|
failure while the caller is reporting a first one.
|
|
"""
|
|
reconfigure = getattr(stream, "reconfigure", None)
|
|
if reconfigure is None:
|
|
return False
|
|
try:
|
|
reconfigure(encoding="utf-8", errors=errors)
|
|
except (ValueError, OSError):
|
|
return False
|
|
return True
|
|
|
|
|
|
def enable_utf8_stdio(errors: str = DEFAULT_ERRORS) -> None:
|
|
"""Re-encode ``sys.stdout`` and ``sys.stderr`` as UTF-8 for this process.
|
|
|
|
Idempotent, and safe to call when the streams are redirected, wrapped or
|
|
replaced: a stream that cannot be reconfigured is skipped silently.
|
|
|
|
@param errors Codec error handler to install (default
|
|
:data:`DEFAULT_ERRORS`, which never raises).
|
|
@return None
|
|
"""
|
|
_reconfigure(sys.stdout, errors)
|
|
_reconfigure(sys.stderr, errors)
|