西风逍遥游
34d1fdb63b
* chore(ci): add clang-format gate, CODEOWNERS and agent collaboration rules * refactor(modules): clear remaining back-edges and split the largest TUs Three known dependency back-edges are gone (module_depgraph.py KNOWN_BACK_EDGES is now empty; --check passes with 0 violations, 0 cycles): - window -> graphics: window queries the new IWindowSurfaceHost capability (common/WindowSurfaceHost.h) instead of holding a Graphics pointer; Window::setGraphics was removed and all call sites updated. - window -> image: Window::setIcon was replaced by setIconRGBA(const uint8_t*, w, h); the window no longer decodes ImageData. - scene -> graphics: pickScreenAt / collectFrustumIdsAt implementations moved to graphics/ScenePicking.cpp (graphics -> scene is a legal downward edge); scene now depends only on spatial. TU splits (pure moves, verified identical method sets and brace balance): - vulkan/Graphics.cpp (5118 lines) -> Graphics.cpp (lifecycle), GraphicsPipeline, Graphics2D, Graphics3D, GraphicsMesh + shared GraphicsInternal.h. - scene/Scene.cpp -> Scene.cpp (script layer / host lifecycle / serialization) + SceneNodes.cpp + shared SceneInternal.h. Verified with a real build (MSVC 19.51, prebuilt third-party): full build green; window.* and Scene.* suites pass, including scene picking/culling and GPU cases. * refactor(graphics): narrow Graphics interfaces and clear public-header leaks Step 4 — interface segregation: - New lean interfaces: IGraphics2D, IGraphics3D, IResourceFactory, IPostFX (pure virtuals, forward-declared types only; graphics/Color.h extracted from Canvas.h so modules that only need the color type stop pulling Canvas.h). - Graphics now implements all four facets; consumers can depend on the narrow interface they use instead of the 129-method god class. - Migrated voxel (VoxelWorld::drawVisible -> IGraphics3D*) and model3d (ModelRenderer::buildRenderable(s) -> IResourceFactory&). - Graphics.h slims from 24 sub-header includes to a handful of small type headers + forward declarations; the destructor moved out-of-line so unique_ptr effect members are destroyed where types are complete. Step 5 — header leaks (module_depgraph.py '*' marks: 14 -> 7): - map/TileLayer.h, particles/ParticleEmitter.h, avatar/AvatarInstance.h, animation/SpineAnim.h, map/TileSystem.h, model3d/ModelData.h, model3d/ModelRenderer.h, audio/Audio.h + Source.h, image/ImageData.h + Image.h, dialogue/Dialogue.h, procgen Palette/OutputSpec/TextureRecipe/ PbrMaterial -> forward declarations, includes moved to .cpp. - voxel/VoxelWorld.h: terrain sampler Pimpl'd (unique_ptr + out-of-line destructor), removing the procgen header dependency. - gpgpu/vulkan backend headers stop pulling graphics/vulkan/Graphics.h. - Remaining '*' marks are deliberate: tiny POD/enum headers (GridConfig, MapObject, BlendMode, Color), an internal backend header (GraphicsInternal.h -> filesystem), and lean interface references. Verified with a full clean build (MSVC) and tests: window/Scene/voxel/ RenderSystem/Quad/shader/TextureSampler/resourceLifetime pass; broad suite only shows the pre-existing PHYSFS-init filesystem-environment failures. * feat(resources): revive ResourceManager as unified IAssetReloader-backed cache * fix(resources): leak ResourceManager singleton to avoid exit-time teardown crashes Cached CPU resources may own third-party handles (FreeType faces, Assimp scenes, image decode handlers) whose libraries are torn down at process exit in an unspecified TU order; destroying cached entries from the singleton destructor can segfault at exit (seen on CI Windows in model3d.materialApi.objMtl). Keep the singleton alive until OS reclaim; explicit unload()/clear() still release entries during the run. * refactor(devtools): consume business modules through capability interfaces DevTools / cmdline no longer include business-module headers, so trimming scene / physics / procgen / particles / audio / ui / graphics no longer requires disabling devtools, and devtools can be switched off with -DEVENGINE_MODULE_DEVTOOLS=OFF. New capability interfaces in common/: - ISceneQuery (scene) - host/node inspection + mutation + transform sync - IRenderCapture (graphics) - render status, PNG capture, camera control, visible-entity snapshot, entity-ID mask, G-buffer PNGs - IPhysicsQuery (physics) - 2D world lifecycle + ray casts - IProcgenQuery (procgen) - recipe listing, map/mesh generation - IParticlesQuery (particles) - emitter status + one-shot emit - IAudioQuery (audio) - volume / stop-all - IEditorHost (ui) - declarative editor host (used by cmdline too) Providers register in their module constructors. DevTools rewires McpServer (render/scene/procgen/physics/particles/audio/host tools), SceneInspect (now delegates to ISceneQuery + IRenderCapture) and RenderVision (uses IRenderCapture::capturePngDataUrl); cmdline/Mcp.cpp uses IEditorHost. manifest: devtools DEPS graphics scene physics procgen particles audio ui image event filesystem -> event; cmdline DEPS filesystem ui -> filesystem. Verified: full build green; devtools.mcp.* tests pass; broad suite shows only the pre-existing PHYSFS-init filesystem-environment failures. * style: apply clang-format to changed lines after dev merge * fix(webgpu): include RenderControl/TextureSampler explicitly after Graphics.h slimming * fix(webgpu): provide newFont/print stubs to satisfy IGraphics2D/IResourceFactory vtables * fix(common): make ProcgenQuery.h self-sufficient (cstdint/utility for GCC)
61 lines
2.2 KiB
Bash
61 lines
2.2 KiB
Bash
#!/usr/bin/env bash
|
|
# Fail when the PR's changed lines are not clang-format clean.
|
|
#
|
|
# Usage: bash .github/scripts/check-format.sh [base-sha]
|
|
# base-sha defaults to origin/dev; for pull_request events CI passes
|
|
# github.event.pull_request.base.sha so the check is stable even while dev
|
|
# moves.
|
|
#
|
|
# Only changed lines of *existing* files are checked (git clang-format), so
|
|
# pre-existing formatting debt in untouched regions does not block a PR.
|
|
# Brand-new files are skipped with a warning: the legacy codebase is not yet
|
|
# clang-format clean, and files created by mechanical refactors (splits/moves)
|
|
# inherit that style. Format new files by hand; tighten this once the repo has
|
|
# been formatted once.
|
|
set -euo pipefail
|
|
|
|
if ! command -v clang-format >/dev/null 2>&1; then
|
|
echo "error: clang-format not found on PATH" >&2
|
|
echo " CI installs clang-format-18 and symlinks it; develop locally with:" >&2
|
|
echo " sudo apt-get install -y clang-format-18 && sudo ln -sf /usr/bin/clang-format-18 /usr/local/bin/clang-format" >&2
|
|
exit 1
|
|
fi
|
|
|
|
BASE="${1:-origin/dev}"
|
|
if ! git rev-parse --verify --quiet "$BASE" >/dev/null; then
|
|
echo "warning: base '$BASE' is not a commit; falling back to origin/dev" >&2
|
|
BASE="origin/dev"
|
|
fi
|
|
if ! git rev-parse --verify --quiet "$BASE" >/dev/null; then
|
|
echo "warning: origin/dev not available; skipping format check" >&2
|
|
exit 0
|
|
fi
|
|
|
|
MERGE_BASE="$(git merge-base "$BASE" HEAD)"
|
|
DIFF_FILE="$(mktemp)"
|
|
trap 'rm -f "$DIFF_FILE"' EXIT
|
|
|
|
CHANGED_FILES="$(git diff --name-only "$MERGE_BASE" HEAD -- '*.cpp' '*.h' '*.hpp')"
|
|
if [ -z "$CHANGED_FILES" ]; then
|
|
echo "ok: no C/C++ files changed"
|
|
exit 0
|
|
fi
|
|
|
|
for file in $CHANGED_FILES; do
|
|
if ! git cat-file -e "$MERGE_BASE:$file" 2>/dev/null; then
|
|
echo "warning: new file '$file' is not checked (format it by hand)"
|
|
continue
|
|
fi
|
|
# --diff exits non-zero when differences are found; keep going so we can
|
|
# print the diff as the failure message.
|
|
git clang-format --diff "$MERGE_BASE" -- "$file" >>"$DIFF_FILE" || true
|
|
done
|
|
|
|
if [ -s "$DIFF_FILE" ]; then
|
|
echo "error: changed lines are not clang-format clean (see .clang-format):" >&2
|
|
cat "$DIFF_FILE" >&2
|
|
exit 1
|
|
fi
|
|
|
|
echo "ok: changed lines are clang-format clean"
|