* chore(ci): add clang-format gate, CODEOWNERS and agent collaboration rules * refactor(modules): clear remaining back-edges and split the largest TUs Three known dependency back-edges are gone (module_depgraph.py KNOWN_BACK_EDGES is now empty; --check passes with 0 violations, 0 cycles): - window -> graphics: window queries the new IWindowSurfaceHost capability (common/WindowSurfaceHost.h) instead of holding a Graphics pointer; Window::setGraphics was removed and all call sites updated. - window -> image: Window::setIcon was replaced by setIconRGBA(const uint8_t*, w, h); the window no longer decodes ImageData. - scene -> graphics: pickScreenAt / collectFrustumIdsAt implementations moved to graphics/ScenePicking.cpp (graphics -> scene is a legal downward edge); scene now depends only on spatial. TU splits (pure moves, verified identical method sets and brace balance): - vulkan/Graphics.cpp (5118 lines) -> Graphics.cpp (lifecycle), GraphicsPipeline, Graphics2D, Graphics3D, GraphicsMesh + shared GraphicsInternal.h. - scene/Scene.cpp -> Scene.cpp (script layer / host lifecycle / serialization) + SceneNodes.cpp + shared SceneInternal.h. Verified with a real build (MSVC 19.51, prebuilt third-party): full build green; window.* and Scene.* suites pass, including scene picking/culling and GPU cases. * refactor(graphics): narrow Graphics interfaces and clear public-header leaks Step 4 — interface segregation: - New lean interfaces: IGraphics2D, IGraphics3D, IResourceFactory, IPostFX (pure virtuals, forward-declared types only; graphics/Color.h extracted from Canvas.h so modules that only need the color type stop pulling Canvas.h). - Graphics now implements all four facets; consumers can depend on the narrow interface they use instead of the 129-method god class. - Migrated voxel (VoxelWorld::drawVisible -> IGraphics3D*) and model3d (ModelRenderer::buildRenderable(s) -> IResourceFactory&). - Graphics.h slims from 24 sub-header includes to a handful of small type headers + forward declarations; the destructor moved out-of-line so unique_ptr effect members are destroyed where types are complete. Step 5 — header leaks (module_depgraph.py '*' marks: 14 -> 7): - map/TileLayer.h, particles/ParticleEmitter.h, avatar/AvatarInstance.h, animation/SpineAnim.h, map/TileSystem.h, model3d/ModelData.h, model3d/ModelRenderer.h, audio/Audio.h + Source.h, image/ImageData.h + Image.h, dialogue/Dialogue.h, procgen Palette/OutputSpec/TextureRecipe/ PbrMaterial -> forward declarations, includes moved to .cpp. - voxel/VoxelWorld.h: terrain sampler Pimpl'd (unique_ptr + out-of-line destructor), removing the procgen header dependency. - gpgpu/vulkan backend headers stop pulling graphics/vulkan/Graphics.h. - Remaining '*' marks are deliberate: tiny POD/enum headers (GridConfig, MapObject, BlendMode, Color), an internal backend header (GraphicsInternal.h -> filesystem), and lean interface references. Verified with a full clean build (MSVC) and tests: window/Scene/voxel/ RenderSystem/Quad/shader/TextureSampler/resourceLifetime pass; broad suite only shows the pre-existing PHYSFS-init filesystem-environment failures. * feat(resources): revive ResourceManager as unified IAssetReloader-backed cache * fix(resources): leak ResourceManager singleton to avoid exit-time teardown crashes Cached CPU resources may own third-party handles (FreeType faces, Assimp scenes, image decode handlers) whose libraries are torn down at process exit in an unspecified TU order; destroying cached entries from the singleton destructor can segfault at exit (seen on CI Windows in model3d.materialApi.objMtl). Keep the singleton alive until OS reclaim; explicit unload()/clear() still release entries during the run. * refactor(devtools): consume business modules through capability interfaces DevTools / cmdline no longer include business-module headers, so trimming scene / physics / procgen / particles / audio / ui / graphics no longer requires disabling devtools, and devtools can be switched off with -DEVENGINE_MODULE_DEVTOOLS=OFF. New capability interfaces in common/: - ISceneQuery (scene) - host/node inspection + mutation + transform sync - IRenderCapture (graphics) - render status, PNG capture, camera control, visible-entity snapshot, entity-ID mask, G-buffer PNGs - IPhysicsQuery (physics) - 2D world lifecycle + ray casts - IProcgenQuery (procgen) - recipe listing, map/mesh generation - IParticlesQuery (particles) - emitter status + one-shot emit - IAudioQuery (audio) - volume / stop-all - IEditorHost (ui) - declarative editor host (used by cmdline too) Providers register in their module constructors. DevTools rewires McpServer (render/scene/procgen/physics/particles/audio/host tools), SceneInspect (now delegates to ISceneQuery + IRenderCapture) and RenderVision (uses IRenderCapture::capturePngDataUrl); cmdline/Mcp.cpp uses IEditorHost. manifest: devtools DEPS graphics scene physics procgen particles audio ui image event filesystem -> event; cmdline DEPS filesystem ui -> filesystem. Verified: full build green; devtools.mcp.* tests pass; broad suite shows only the pre-existing PHYSFS-init filesystem-environment failures. * style: apply clang-format to changed lines after dev merge * fix(webgpu): include RenderControl/TextureSampler explicitly after Graphics.h slimming * fix(webgpu): provide newFont/print stubs to satisfy IGraphics2D/IResourceFactory vtables * fix(common): make ProcgenQuery.h self-sufficient (cstdint/utility for GCC)
75 lines
3.1 KiB
C++
75 lines
3.1 KiB
C++
#include "common/Capability.h"
|
|
#include "common/EditorHost.h"
|
|
#include "ui/EditorHost.h"
|
|
|
|
#include <string>
|
|
|
|
namespace eve::ui {
|
|
namespace {
|
|
|
|
class EditorHostImpl final : public eve::IEditorHost {
|
|
public:
|
|
std::string status() const override { return EditorHost::instance().status(); }
|
|
std::string openWindow(const std::string &title, int width, int height) override {
|
|
return EditorHost::instance().openWindow(title, width, height);
|
|
}
|
|
std::string closeWindow() override { return EditorHost::instance().closeWindow(); }
|
|
std::string windowState() const override { return EditorHost::instance().windowState(); }
|
|
std::string applyEditor(const std::string &json) override {
|
|
return EditorHost::instance().applyEditor(json);
|
|
}
|
|
std::string removeEditor(const std::string &id) override {
|
|
return EditorHost::instance().removeEditor(id);
|
|
}
|
|
std::string listEditors() const override { return EditorHost::instance().listEditors(); }
|
|
std::string editorState(const std::string &id) const override {
|
|
return EditorHost::instance().editorState(id);
|
|
}
|
|
std::string setEditorValue(const std::string &editorId, const std::string &widgetId,
|
|
const std::string &value) override {
|
|
return EditorHost::instance().setEditorValue(editorId, widgetId, value);
|
|
}
|
|
std::string consumeEvents(const std::string &editorId) override {
|
|
return EditorHost::instance().consumeEvents(editorId);
|
|
}
|
|
std::string widgetRect(const std::string &editorId,
|
|
const std::string &widgetId) const override {
|
|
return EditorHost::instance().widgetRect(editorId, widgetId);
|
|
}
|
|
std::string registerVM(const std::string &name, const std::string &source) override {
|
|
return EditorHost::instance().registerVM(name, source);
|
|
}
|
|
std::string unregisterVM(const std::string &name) override {
|
|
return EditorHost::instance().unregisterVM(name);
|
|
}
|
|
std::string saveEditor(const std::string &id) override {
|
|
return EditorHost::instance().saveEditor(id);
|
|
}
|
|
std::string unloadEditor(const std::string &id) override {
|
|
return EditorHost::instance().unloadEditor(id);
|
|
}
|
|
std::string capture(const std::string &path) override {
|
|
return EditorHost::instance().capture(path);
|
|
}
|
|
std::string runScript(const std::string &source) override {
|
|
return EditorHost::instance().runScript(source);
|
|
}
|
|
void requestExit() override { EditorHost::instance().requestExit(); }
|
|
bool exitRequested() override { return EditorHost::instance().exitRequested(); }
|
|
void frame() override { EditorHost::instance().frame(); }
|
|
void stop() override { EditorHost::instance().stop(); }
|
|
void start(ssq::VM& vm, const std::string& gameRoot, bool allowWindow) override {
|
|
EditorHost::instance().start(vm, gameRoot, allowWindow);
|
|
}
|
|
void exposeScriptApi(ssq::VM& vm) override { EditorHost::instance().exposeScriptApi(vm); }
|
|
};
|
|
|
|
} // namespace
|
|
|
|
void registerEditorHostCapabilities() {
|
|
static EditorHostImpl impl;
|
|
eve::cap::provide<eve::IEditorHost>(&impl);
|
|
}
|
|
|
|
} // namespace eve::ui
|