Kaede AkinoandClaude Opus 5
d7029a0557
Context was decoration. Three defects, all reported from use. Session context followed the conversation. `ConversationModel` owned the chips and the remote system info, and `refreshAssistantContext` stamped the focused pane onto whichever chat the sidebar was showing — so sending from the sidebar carried a host and directory into the Assistant tab, which has no session to describe. It now lives on `WindowSidebarState` as a `SessionContext`, and `ComposerView` takes it as a parameter defaulting to `.none`. The Assistant tab passes nothing, so it cannot show or send a session it does not have. Two bugs fell out with it: leaving a Workspace clears the context instead of freezing the last value, and opening a chat in the sidebar no longer marks it. Nothing was sent. Only `RemoteSystemInfo` reached the model; host and cwd reached nothing, and `ContextChip` had no payload at all — the SSH-failure attachment was a label for a log pasted into the draft. `SessionContext.modelContext` now renders one fenced data-only block into the run's system prompt, chips carry their content, and `appendUserTurn` folds attachments into the turn it returns. What was uploaded is literally what the bubble shows. Titles were the first message. `ConversationTitleService` mirrors `CommandComposerService` — tool-free, strict JSON, validated — and resolves `.chat` rather than adding a Titler role, per the argument already written into `AIRole`. It runs once after the first reply and persists to the `title` column that existed but was never read back, so no migration. It reads `transcript`, not `messages`: a failed run writes its reason to the visible list alone, and that is not a name. `Pane.remoteSystemInfo` already withholds the probe when Shell Integration is off, so the second gate in `AppModel` is gone — the value sent is the value the chips were drawn from, and the two cannot disagree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
695 lines
28 KiB
Swift
695 lines
28 KiB
Swift
import Foundation
|
|
import Testing
|
|
|
|
@testable import Termind
|
|
|
|
@Suite
|
|
@MainActor
|
|
struct WindowStateTests {
|
|
@Test
|
|
func newWindowStartsOnWelcome() {
|
|
let window = WindowModel()
|
|
|
|
#expect(window.selectedTopLevelTab == .vault)
|
|
#expect(window.vaultDestination == .welcome)
|
|
}
|
|
|
|
@Test
|
|
func pinnedVaultAndAssistantPrecedeDynamicWorkspaces() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
window.select(index: 0)
|
|
#expect(window.selectedTopLevelTab == .vault)
|
|
window.select(index: 1)
|
|
#expect(window.selectedTopLevelTab == .assistant)
|
|
window.select(index: 2)
|
|
#expect(window.selectedTopLevelTab == .workspace(workspace.id))
|
|
|
|
window.selectVault()
|
|
window.closeSelected()
|
|
#expect(window.tabs.map(\.id) == [workspace.id])
|
|
}
|
|
|
|
@Test
|
|
func assistantFeatureOwnsConversationLifecycleOutsideWorkspaces() {
|
|
let window = WindowModel()
|
|
let first = window.openAssistant()
|
|
let second = window.openAssistant()
|
|
|
|
#expect(window.selectedTopLevelTab == .assistant)
|
|
#expect(window.tabs.isEmpty)
|
|
#expect(window.assistantLibrary.conversations.map(\.id) == [second.id, first.id])
|
|
|
|
window.assistantLibrary.delete(second.id)
|
|
#expect(window.assistantLibrary.selectedConversationID == first.id)
|
|
}
|
|
|
|
/// Each window used to build its own `ConversationModel` for the same
|
|
/// conversation id, so a reply streaming in one window was invisible in the
|
|
/// other and both could start a run against the same stored history.
|
|
@Test
|
|
func twoWindowsShareOneInstanceOfEachConversationButNotTheSelection() {
|
|
let shared = AssistantConversationStore()
|
|
let first = WindowModel()
|
|
let second = WindowModel()
|
|
first.assistantLibrary.adopt(shared)
|
|
second.assistantLibrary.adopt(shared)
|
|
|
|
let conversation = first.openAssistant()
|
|
let other = first.openAssistant()
|
|
|
|
#expect(second.assistantLibrary.conversations.map(\.id) == [other.id, conversation.id])
|
|
#expect(second.assistantLibrary.conversation(id: conversation.id) === conversation)
|
|
|
|
second.selectAssistant(conversation.id)
|
|
#expect(second.assistantLibrary.selectedConversationID == conversation.id)
|
|
#expect(first.assistantLibrary.selectedConversationID == other.id)
|
|
|
|
// A delete in one window empties the other's stale selection too.
|
|
first.assistantLibrary.delete(conversation.id)
|
|
second.assistantLibrary.delete(conversation.id)
|
|
#expect(second.assistantLibrary.conversations.map(\.id) == [other.id])
|
|
#expect(second.assistantLibrary.selectedConversationID == other.id)
|
|
}
|
|
|
|
@Test
|
|
func aWindowThatAdoptsTheStoreLateKeepsWhatItAlreadyHad() {
|
|
let window = WindowModel()
|
|
let early = window.openAssistant()
|
|
|
|
let shared = AssistantConversationStore()
|
|
window.assistantLibrary.adopt(shared)
|
|
|
|
#expect(shared.conversations.map(\.id) == [early.id])
|
|
#expect(window.assistantLibrary.selectedConversationID == early.id)
|
|
}
|
|
|
|
@Test
|
|
func selectingAssistantDoesNotCreateAConversation() {
|
|
let window = WindowModel()
|
|
|
|
window.selectAssistant()
|
|
|
|
#expect(window.selectedTopLevelTab == .assistant)
|
|
#expect(window.assistantLibrary.conversations.isEmpty)
|
|
#expect(window.assistantLibrary.selectedConversation == nil)
|
|
}
|
|
|
|
@Test
|
|
func sidebarDraftCreatesConversationOnlyOnFirstValidSend() {
|
|
let workspace = Workspace.sshSession(host: Host(name: "Server", host: "server.example"))
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
#expect(window.sendAssistantSidebarDraft() == nil)
|
|
#expect(window.assistantLibrary.conversations.isEmpty)
|
|
|
|
window.sidebar.assistantDraft.draft = " Explain this failure. "
|
|
let conversation = window.sendAssistantSidebarDraft()
|
|
|
|
#expect(conversation?.messages.map(\.text) == ["Explain this failure."])
|
|
#expect(window.assistantLibrary.conversations.count == 1)
|
|
#expect(window.assistantLibrary.conversations.first?.id == conversation?.id)
|
|
#expect(window.sidebarAssistantConversation?.id == conversation?.id)
|
|
#expect(window.selectedTopLevelTab == .workspace(workspace.id))
|
|
#expect(window.sidebar.assistantDraft.isEmpty)
|
|
}
|
|
|
|
@Test
|
|
func sidebarConversationNavigationIsIndependentAndDeletionReturnsHome() {
|
|
let workspace = Workspace.sshSession(host: Host(name: "Server", host: "server.example"))
|
|
let conversation = ConversationModel()
|
|
conversation.draft = "Hello"
|
|
let library = AssistantLibraryModel()
|
|
_ = library.startConversation(conversation)
|
|
let window = WindowModel(tabs: [workspace], assistantLibrary: library)
|
|
|
|
window.openAssistantInSidebar(conversation.id)
|
|
#expect(window.sidebarAssistantConversation?.id == conversation.id)
|
|
#expect(window.selectedTopLevelTab == .workspace(workspace.id))
|
|
|
|
window.closeAssistantInSidebar()
|
|
#expect(window.sidebarAssistantConversation == nil)
|
|
|
|
window.openAssistantInSidebar(conversation.id)
|
|
window.deleteAssistantConversation(conversation.id)
|
|
#expect(window.sidebarAssistantConversation == nil)
|
|
#expect(window.assistantLibrary.conversations.isEmpty)
|
|
}
|
|
|
|
@Test
|
|
func assistantSidebarShowsFocusedWorkspaceContext() {
|
|
let host = Host(name: "Files", host: "files.example")
|
|
let workspace = Workspace.sftpSession(host: host, initialPath: "/srv/app")
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
window.hostStore = HostStore(hosts: [host])
|
|
|
|
#expect(window.sidebar.sessionContext.chips.map(\.kind) == [.host, .directory])
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Files", "/srv/app"])
|
|
}
|
|
|
|
@Test
|
|
func focusedSFTPPathChangesUpdateSessionContext() {
|
|
let host = Host(name: "Files", host: "files.example")
|
|
let workspace = Workspace.sftpSession(host: host, initialPath: "/srv")
|
|
let sftpSession = workspace.focusedPane.sftpSession!
|
|
let window = WindowModel(tabs: [workspace])
|
|
window.hostStore = HostStore(hosts: [host])
|
|
|
|
sftpSession.navigate(to: "/srv/releases")
|
|
|
|
#expect(window.sidebar.sessionContext.chips.map(\.kind) == [.host, .directory])
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Files", "/srv/releases"])
|
|
|
|
sftpSession.goBack()
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Files", "/srv"])
|
|
}
|
|
|
|
@Test
|
|
func backgroundSFTPPathDoesNotReplaceFocusedPaneContext() {
|
|
let host = Host(name: "Files", host: "files.example")
|
|
let workspace = Workspace.sftpSession(host: host, initialPath: "/focused")
|
|
let focusedPane = workspace.focusedPane
|
|
workspace.splitFocusedPane(
|
|
axis: .horizontal,
|
|
with: .sftpSession(host: host, initialPath: "/background")
|
|
)
|
|
let backgroundSession = workspace.focusedPane.sftpSession!
|
|
workspace.focus(focusedPane.id)
|
|
let window = WindowModel(tabs: [workspace])
|
|
window.hostStore = HostStore(hosts: [host])
|
|
|
|
backgroundSession.navigate(to: "/background/changed")
|
|
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Files", "/focused"])
|
|
}
|
|
|
|
/// The reported leak: session context must belong to the sidebar, so a
|
|
/// conversation promoted out of it arrives in the Assistant tab carrying
|
|
/// nothing about a host it can no longer see.
|
|
@Test
|
|
func sendingFromTheSidebarDoesNotAttachSessionContextToTheConversation() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sftpSession(host: host, initialPath: "/srv/app")
|
|
let window = WindowModel(tabs: [workspace])
|
|
window.hostStore = HostStore(hosts: [host])
|
|
window.sidebar.assistantDraft.draft = "Why is this slow?"
|
|
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Server", "/srv/app"])
|
|
|
|
let conversation = window.sendAssistantSidebarDraft()
|
|
|
|
#expect(conversation?.attachments.isEmpty == true)
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Server", "/srv/app"])
|
|
}
|
|
|
|
/// Leaving every Workspace used to freeze the last host and directory on
|
|
/// screen, because the refresh returned early instead of clearing.
|
|
@Test
|
|
func leavingEveryWorkspaceClearsSessionContext() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sftpSession(host: host, initialPath: "/srv/app")
|
|
let window = WindowModel(tabs: [workspace])
|
|
window.hostStore = HostStore(hosts: [host])
|
|
|
|
#expect(!window.sidebar.sessionContext.isEmpty)
|
|
|
|
window.selectVault()
|
|
window.refreshSessionContext()
|
|
|
|
#expect(window.sidebar.sessionContext == .none)
|
|
}
|
|
|
|
/// The path `askAI` takes: attach the failure log, promote the draft, and
|
|
/// the log goes with the message it belongs to rather than sitting in the
|
|
/// draft as text the user could half-delete.
|
|
@Test
|
|
func promotingASidebarDraftSendsItsAttachmentWithTheFirstTurn() {
|
|
let conversation = ConversationModel()
|
|
conversation.attach(
|
|
ContextChip(kind: .output, label: "Connection error", content: "ssh: refused")
|
|
)
|
|
conversation.draft = "Explain this"
|
|
|
|
_ = AssistantLibraryModel().startConversation(conversation)
|
|
|
|
let first = conversation.messages.first?.text ?? ""
|
|
#expect(first.hasPrefix("Explain this"))
|
|
#expect(first.contains("ssh: refused"))
|
|
#expect(conversation.attachments.isEmpty, "the attachment went with the turn")
|
|
}
|
|
|
|
/// Opening a conversation in the sidebar used to stamp the focused pane's
|
|
/// host onto it, which is how that host followed the conversation into the
|
|
/// Assistant tab.
|
|
@Test
|
|
func openingASidebarConversationLeavesItUnmarkedByTheFocusedPane() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let conversation = ConversationModel()
|
|
conversation.draft = "Explain this"
|
|
let library = AssistantLibraryModel()
|
|
_ = library.startConversation(conversation)
|
|
conversation.attach(
|
|
ContextChip(kind: .output, label: "Connection error", content: "ssh: refused")
|
|
)
|
|
let window = WindowModel(tabs: [workspace], assistantLibrary: library)
|
|
window.hostStore = HostStore(hosts: [host])
|
|
|
|
window.openAssistantInSidebar(conversation.id)
|
|
|
|
#expect(conversation.attachments.map(\.label) == ["Connection error"])
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Server"])
|
|
}
|
|
|
|
@Test
|
|
func focusedSSHDirectoryChangesUpdateSessionContext() async {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let sshSession = workspace.focusedPane.sshSession!
|
|
let window = WindowModel(tabs: [workspace])
|
|
window.hostStore = HostStore(hosts: [host])
|
|
|
|
sshSession.terminalState.terminalDidChangeWorkingDirectory("/var/log")
|
|
await Task.yield()
|
|
|
|
#expect(window.sidebar.sessionContext.chips.map(\.kind) == [.host, .directory])
|
|
#expect(window.sidebar.sessionContext.chips.map(\.label) == ["Server", "/var/log"])
|
|
|
|
sshSession.disconnect()
|
|
#expect(window.sidebar.sessionContext.chips.map(\.kind) == [.host])
|
|
}
|
|
|
|
@Test
|
|
func focusedSSHSystemInfoUpdatesSessionContextAndSFTPClearsIt() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let sshPane = workspace.focusedPane
|
|
let sshSession = sshPane.sshSession!
|
|
let window = WindowModel(tabs: [workspace])
|
|
window.hostStore = HostStore(hosts: [host])
|
|
let info = RemoteSystemInfo(
|
|
distributionID: "ubuntu", distributionVersion: "24.04",
|
|
kernelName: "Linux", kernelRelease: "6.8.0", architecture: "x86_64"
|
|
)
|
|
|
|
sshSession.receiveShellIntegrationEvent(.available(shell: "bash", systemInfo: info))
|
|
|
|
#expect(window.sidebar.sessionContext.systemInfo == info)
|
|
// OS facts reach the model but are not a pill: they are disclosed by the
|
|
// Shell Integration setting, not by the composer.
|
|
#expect(window.sidebar.sessionContext.chips.map(\.kind) == [.host])
|
|
|
|
workspace.splitFocusedPane(axis: .horizontal, with: .sftpSession(host: host))
|
|
#expect(window.sidebar.sessionContext.systemInfo == nil)
|
|
|
|
workspace.focus(sshPane.id)
|
|
#expect(window.sidebar.sessionContext.systemInfo == info)
|
|
|
|
sshSession.applyShellIntegrationPreference(isEnabled: false)
|
|
#expect(window.sidebar.sessionContext.systemInfo == nil)
|
|
|
|
sshSession.receiveShellIntegrationEvent(.available(shell: "bash", systemInfo: info))
|
|
sshSession.disconnect()
|
|
#expect(window.sidebar.sessionContext.systemInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
func vaultRoutesNeverBecomeWorkspaceTabs() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
window.openPage(.hosts)
|
|
#expect(window.selectedTopLevelTab == .vault)
|
|
#expect(window.vaultDestination == .hosts)
|
|
#expect(window.tabs.map(\.id) == [workspace.id])
|
|
|
|
window.select(workspace.id)
|
|
#expect(window.selectedTopLevelTab == .workspace(workspace.id))
|
|
}
|
|
|
|
@Test
|
|
func draggingSelectedWorkspaceDisplaysNeighbourAsMergeTarget() {
|
|
let first = Workspace.sshSession(host: Host(name: "First", host: "first.example"))
|
|
let second = Workspace.sshSession(host: Host(name: "Second", host: "second.example"))
|
|
let window = WindowModel(tabs: [first, second])
|
|
window.select(first.id)
|
|
|
|
window.dragging = .workspace(first.id)
|
|
|
|
#expect(window.displayedTab?.id == second.id)
|
|
#expect(window.selectedTab?.id == first.id)
|
|
}
|
|
|
|
@Test
|
|
func hostEditorIsVaultNavigationAndCloseTabCannotCloseHiddenWork() {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
window.openHostEditor(host: host)
|
|
#expect(window.selectedTopLevelTab == .vault)
|
|
#expect(window.vaultDestination == .hosts)
|
|
#expect(window.vaultWorkRoute == .hostEditor(host.id))
|
|
window.closeSelected()
|
|
#expect(window.tabs.map(\.id) == [workspace.id])
|
|
}
|
|
|
|
@Test
|
|
func changingVaultPageClosesRightColumnWork() {
|
|
let window = WindowModel(vaultDestination: .hosts)
|
|
|
|
window.openVaultWork(
|
|
.snippetEditor(snippetID: nil, packageID: nil), on: .snippets
|
|
)
|
|
#expect(window.vaultDestination == .snippets)
|
|
#expect(window.vaultWorkRoute == .snippetEditor(snippetID: nil, packageID: nil))
|
|
|
|
window.openPage(.keychain)
|
|
#expect(window.vaultDestination == .keychain)
|
|
#expect(window.vaultWorkRoute == nil)
|
|
}
|
|
|
|
@Test
|
|
func windowsKeepPresentationAndContextPanelStateIsolated() {
|
|
let first = WindowModel(vaultDestination: .hosts)
|
|
let second = WindowModel(vaultDestination: .hosts)
|
|
let host = UUID()
|
|
|
|
first.hostChooser = .connect
|
|
first.selectDetail(.host(host), on: .hosts)
|
|
|
|
#expect(first.hostChooser == .connect)
|
|
#expect(second.hostChooser == nil)
|
|
#expect(second.detailSelection(for: .hosts).isEmpty)
|
|
}
|
|
|
|
@Test
|
|
func windowSheetRouteIsMutuallyExclusive() {
|
|
let state = WindowPresentationState()
|
|
|
|
state.hostChooser = .connect
|
|
#expect(state.hostChooser == .connect)
|
|
state.hostChooser = .batchStartup
|
|
#expect(state.hostChooser == .batchStartup)
|
|
state.hostChooser = nil
|
|
#expect(state.sheet == nil)
|
|
}
|
|
|
|
@Test
|
|
func contextPanelOverrideExpiresWhenFocusLeavesItsPane() {
|
|
let firstHost = Host(name: "First", host: "first.example")
|
|
let secondHost = Host(name: "Second", host: "second.example")
|
|
let first = Workspace.sshSession(host: firstHost)
|
|
let second = Workspace.sshSession(host: secondHost)
|
|
let window = WindowModel(tabs: [first, second])
|
|
window.selectedTabID = first.id
|
|
|
|
window.sidebar.show(.snippet(UUID()), scopedTo: first.focusedPane)
|
|
#expect(window.activeDetailSelection.first?.kind == ContextPanelDetailID.Kind.snippet)
|
|
|
|
window.selectedTabID = second.id
|
|
window.sidebar.focusedPaneDidChange(to: second.focusedPane)
|
|
#expect(window.activeDetailSelection == [.host(secondHost.id)])
|
|
}
|
|
|
|
@Test
|
|
func featureRoutesReplaceRatherThanStack() {
|
|
let window = WindowModel(vaultDestination: .hosts)
|
|
let groupID = UUID()
|
|
window.openVaultWork(
|
|
.hostGroupEditor(groupID: nil, parentID: nil), on: .hosts
|
|
)
|
|
window.openVaultWork(
|
|
.hostGroupEditor(groupID: groupID, parentID: nil), on: .hosts
|
|
)
|
|
#expect(
|
|
window.vaultWorkRoute
|
|
== .hostGroupEditor(groupID: groupID, parentID: nil)
|
|
)
|
|
|
|
let snippets = SnippetsPageState()
|
|
let batch = SnippetBatch(snippets: [])
|
|
snippets.confirmation = .executeDestructive(batch)
|
|
snippets.confirmation = .deleteSnippets(batch)
|
|
guard case .deleteSnippets = snippets.confirmation else {
|
|
Issue.record("Expected one active snippet confirmation route")
|
|
return
|
|
}
|
|
}
|
|
|
|
@Test
|
|
func sessionsMixSSHAndSFTPInTabAndPaneOrder() {
|
|
let firstHost = Host(name: "First", host: "first.example")
|
|
let secondHost = Host(name: "Second", host: "second.example")
|
|
let mixed = Workspace.sshSession(host: firstHost)
|
|
let sshPane = mixed.focusedPane
|
|
mixed.splitFocusedPane(axis: .horizontal, with: .sftpSession(host: firstHost))
|
|
let sftpPane = mixed.focusedPane
|
|
let secondSSH = Workspace.sshSession(host: secondHost)
|
|
let window = WindowModel(tabs: [mixed, secondSSH])
|
|
|
|
#expect(window.sessionPanes.map(\.pane.id) == [sshPane.id, sftpPane.id, secondSSH.focusedPane.id])
|
|
#expect(window.sshSessionPanes.map(\.pane.id) == [sshPane.id, secondSSH.focusedPane.id])
|
|
#expect(window.sftpSessionPanes.map(\.pane.id) == [sftpPane.id])
|
|
#expect(window.sessionPanes.map(\.pane.symbol) == ["apple.terminal", "folder", "apple.terminal"])
|
|
}
|
|
|
|
@Test
|
|
func sftpTitlesUseHostNameWithoutPrefixAndFallBackToSFTP() {
|
|
let host = Host(name: "Uploads", host: "uploads.example")
|
|
let store = HostStore(hosts: [host])
|
|
let pane = Pane.sftpSession(host: host)
|
|
let missing = Pane(.sftpSession(SFTPSessionModel(hostID: UUID(), initialPath: "/")))
|
|
|
|
#expect(pane.title(in: store) == "Uploads")
|
|
#expect(pane.sidebarTitle(in: store) == "Uploads")
|
|
#expect(missing.title(in: store) == "SFTP")
|
|
#expect(missing.sidebarTitle(in: store) == "SFTP")
|
|
}
|
|
|
|
@Test
|
|
func selectingAndClosingUnifiedSessionPanesKeepsWorkspaceStateConsistent() {
|
|
let host = Host(name: "Host", host: "host.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let sshPane = workspace.focusedPane
|
|
workspace.splitFocusedPane(axis: .horizontal, with: .sftpSession(host: host))
|
|
let sftpPane = workspace.focusedPane
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
workspace.focus(sshPane.id)
|
|
window.select(workspace.id)
|
|
|
|
workspace.focus(sftpPane.id)
|
|
|
|
window.closePane(sftpPane.id)
|
|
#expect(window.sessionPanes.map(\.pane.id) == [sshPane.id])
|
|
#expect(workspace.focusedPaneID == sshPane.id)
|
|
|
|
window.closePane(sshPane.id)
|
|
#expect(window.sessionPanes.isEmpty)
|
|
#expect(window.tabs.isEmpty)
|
|
}
|
|
|
|
@Test
|
|
func appRoutesHostsToSSHAndSFTPSessionsForTabsAndWorkspaces() {
|
|
let first = Host(name: "First", host: "first.example")
|
|
let second = Host(name: "Second", host: "second.example")
|
|
let store = HostStore(hosts: [first, second])
|
|
let app = AppModel(hosts: store)
|
|
let window = WindowModel()
|
|
|
|
let sshTab = app.open(first, as: .sshSession, in: window)
|
|
let sftpTab = app.open(second, as: .sftpSession, in: window)
|
|
#expect(sshTab.focusedPane.kind == .sshSession)
|
|
#expect(sftpTab.focusedPane.kind == .sftpSession)
|
|
|
|
app.open([first, second], as: .sshSession, layout: .separateTabs, in: window)
|
|
#expect(window.selectedTabID == window.tabs[2].id)
|
|
#expect(window.tabs.suffix(2).map(\.focusedPane.kind) == [.sshSession, .sshSession])
|
|
|
|
app.open([first, second], as: .sftpSession, layout: .oneWorkspace, in: window)
|
|
#expect(window.selectedTab?.panes.map(\.kind) == [.sftpSession, .sftpSession])
|
|
}
|
|
|
|
@Test
|
|
func reopeningAClosedTerminalCreatesAFreshConnectingSession() throws {
|
|
let host = Host(name: "Server", host: "server.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let pane = workspace.focusedPane
|
|
pane.customTitle = "Logs"
|
|
let closedSession = try #require(pane.sshSession)
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
window.close(workspace.id)
|
|
#expect(closedSession.status == .disconnected)
|
|
#expect(window.canReopen)
|
|
|
|
window.reopenLastClosed()
|
|
|
|
let reopenedPane = try #require(window.selectedTab?.focusedPane)
|
|
let reopenedSession = try #require(reopenedPane.sshSession)
|
|
#expect(reopenedSession !== closedSession)
|
|
#expect(reopenedSession.hostID == host.id)
|
|
#expect(reopenedSession.status == .connecting)
|
|
#expect(reopenedPane.customTitle == "Logs")
|
|
#expect(window.selectedTab === workspace)
|
|
#expect(!window.canReopen)
|
|
}
|
|
|
|
@Test
|
|
func terminalPathOpensSFTPInANewTabOrTheCurrentWorkspace() {
|
|
var host = Host(name: "Files", host: "files.example")
|
|
host.sftpSessionInitialPath = "/configured"
|
|
let sshWorkspace = Workspace.sshSession(host: host)
|
|
let window = WindowModel(tabs: [sshWorkspace])
|
|
|
|
let newTab = window.openSFTPSession(
|
|
host: host, initialPath: "/var/log/", placement: .newTab
|
|
)
|
|
|
|
#expect(window.tabs.count == 2)
|
|
#expect(window.selectedTab === newTab)
|
|
#expect(newTab.focusedPane.sftpSession?.path == "/var/log")
|
|
#expect(newTab.focusedPane.sftpSession?.initialPath == "/var/log")
|
|
#expect(host.sftpSessionInitialPath == "/configured")
|
|
|
|
window.select(sshWorkspace.id)
|
|
let result = window.openSFTPSession(
|
|
host: host, initialPath: "/srv/app", placement: .currentWorkspace
|
|
)
|
|
|
|
#expect(result === sshWorkspace)
|
|
#expect(window.tabs.count == 2)
|
|
#expect(sshWorkspace.panes.map(\.kind) == [.sshSession, .sftpSession])
|
|
#expect(sshWorkspace.focusedPane.sftpSession?.path == "/srv/app")
|
|
}
|
|
|
|
@Test
|
|
func sftpPathOpensSSHInANewTabOrTheCurrentWorkspace() throws {
|
|
let host = Host(name: "Shell", host: "shell.example")
|
|
let sftpWorkspace = Workspace.sftpSession(host: host, initialPath: "/configured")
|
|
let window = WindowModel(tabs: [sftpWorkspace])
|
|
|
|
let newTab = window.openSSHSession(
|
|
host: host, initialPath: "/var/log", placement: .newTab
|
|
)
|
|
|
|
#expect(window.tabs.count == 2)
|
|
#expect(window.selectedTab === newTab)
|
|
#expect(newTab.focusedPane.sshSession?.hostID == host.id)
|
|
|
|
window.select(sftpWorkspace.id)
|
|
let result = window.openSSHSession(
|
|
host: host, initialPath: "/srv/app", placement: .currentWorkspace
|
|
)
|
|
|
|
#expect(result === sftpWorkspace)
|
|
#expect(window.tabs.count == 2)
|
|
#expect(sftpWorkspace.panes.map(\.kind) == [.sftpSession, .sshSession])
|
|
#expect(sftpWorkspace.focusedPane.sshSession?.hostID == host.id)
|
|
}
|
|
|
|
@Test
|
|
func sshDirectoryCommandQuotesRemotePaths() {
|
|
#expect(
|
|
WindowModel.changeDirectoryCommand(for: "/srv/it's live")
|
|
== "cd '/srv/it'\"'\"'s live'"
|
|
)
|
|
#expect(WindowModel.changeDirectoryCommand(for: "") == nil)
|
|
}
|
|
|
|
@Test
|
|
func sftpWithoutAnOverrideKeepsTheHostsConfiguredInitialPath() {
|
|
var host = Host(name: "Files", host: "files.example")
|
|
host.sftpSessionInitialPath = "/configured"
|
|
let window = WindowModel()
|
|
|
|
let workspace = window.openSFTPSession(host: host)
|
|
|
|
#expect(workspace.focusedPane.sftpSession?.path == "/configured")
|
|
#expect(workspace.focusedPane.sftpSession?.initialPath == "/configured")
|
|
}
|
|
|
|
@Test
|
|
func duplicateDestinationsPreservePaneAndWorkspaceScope() {
|
|
let host = Host(name: "Host", host: "host.example")
|
|
let original = Workspace.sshSession(host: host)
|
|
let window = WindowModel(tabs: [original])
|
|
|
|
window.duplicateSelected(axis: .horizontal)
|
|
#expect(window.tabs.count == 1)
|
|
#expect(original.panes.count == 2)
|
|
|
|
let focusedPane = original.focusedPane
|
|
window.duplicatePaneInNewTab()
|
|
#expect(window.tabs.count == 2)
|
|
#expect(window.selectedTab?.panes.count == 1)
|
|
#expect(window.selectedTab?.focusedPane.kind == focusedPane.kind)
|
|
|
|
window.select(original.id)
|
|
window.duplicateSelectedInNewTab()
|
|
#expect(window.tabs.count == 3)
|
|
#expect(window.selectedTab?.panes.count == 2)
|
|
#expect(window.selectedTab?.panes.map(\.kind) == original.panes.map(\.kind))
|
|
}
|
|
|
|
@Test
|
|
func normalRemoteExitClosesOnlyItsSplitPane() {
|
|
let firstHost = Host(name: "First", host: "first.example")
|
|
let secondHost = Host(name: "Second", host: "second.example")
|
|
let workspace = Workspace.sshSession(host: firstHost)
|
|
let firstPane = workspace.focusedPane
|
|
let firstSSHSession = firstPane.sshSession!
|
|
workspace.splitFocusedPane(axis: .horizontal, with: .sshSession(host: secondHost))
|
|
let secondPane = workspace.focusedPane
|
|
workspace.focus(firstPane.id)
|
|
workspace.broadcastsInput = true
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
firstSSHSession.handleRemoteExit(.success(0))
|
|
|
|
#expect(window.tabs.count == 1)
|
|
#expect(workspace.panes.map(\.id) == [secondPane.id])
|
|
#expect(workspace.layout.pane(firstPane.id) == nil)
|
|
#expect(workspace.focusedPaneID == secondPane.id)
|
|
#expect(!workspace.broadcastsInput)
|
|
#expect(firstSSHSession.inputRouter == nil)
|
|
}
|
|
|
|
@Test
|
|
func normalRemoteExitClosesLastPaneAndSelectsNeighboringTab() {
|
|
let host = Host(name: "Host", host: "host.example")
|
|
let sshSessionTab = Workspace.sshSession(host: host)
|
|
let sshSession = sshSessionTab.focusedPane.sshSession!
|
|
let neighbor = Workspace.sftpSession(host: host)
|
|
let window = WindowModel(tabs: [sshSessionTab, neighbor])
|
|
window.select(sshSessionTab.id)
|
|
|
|
sshSession.handleRemoteExit(.success(0))
|
|
|
|
#expect(window.tabs.map(\.id) == [neighbor.id])
|
|
#expect(window.selectedTabID == neighbor.id)
|
|
}
|
|
|
|
@Test
|
|
func transportFailureKeepsPaneOpenForReconnect() {
|
|
let host = Host(name: "Host", host: "host.example")
|
|
let workspace = Workspace.sshSession(host: host)
|
|
let sshSession = workspace.focusedPane.sshSession!
|
|
let window = WindowModel(tabs: [workspace])
|
|
|
|
sshSession.handleRemoteExit(.failure(.disconnected))
|
|
|
|
#expect(window.tabs.map(\.id) == [workspace.id])
|
|
#expect(workspace.focusedPane.sshSession === sshSession)
|
|
guard case .failed = sshSession.status else {
|
|
Issue.record("Expected transport failure to remain visible")
|
|
return
|
|
}
|
|
}
|
|
}
|