From d9d3868dc41dfa07c8e5b429855d6665541d5c34 Mon Sep 17 00:00:00 2001 From: bowenliang123 Date: Tue, 13 Oct 2026 23:30:03 +0800 Subject: [PATCH] ci: restore the typecheck gate in both workflows `pnpm test` is the vitest run only since the local pre-commit flow took typecheck over, so neither PR checks nor release builds type-checked anything, and the pr-checks comment still claimed the single test run covered it. Both workflows now run `pnpm run typecheck` beside lint, and the comment says what the vitest run actually covers. --- .github/workflows/pr-checks.yml | 9 ++++++--- .github/workflows/release.yml | 3 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-checks.yml b/.github/workflows/pr-checks.yml index 4e68202..8a78959 100644 --- a/.github/workflows/pr-checks.yml +++ b/.github/workflows/pr-checks.yml @@ -37,6 +37,9 @@ jobs: - name: Lint run: pnpm run lint + - name: Typecheck + run: pnpm run typecheck + # The `compat` vitest project inside `pnpm test` boots the BUILT plugin # against the REAL harness sources at every supported baseline tag # (tests/baselines.ts is the source of truth — keep this fetch list in @@ -53,8 +56,8 @@ jobs: refs/tags/dsh-v0.1.7-rc.2:refs/tags/dsh-v0.1.7-rc.2 \ refs/tags/dsh-v0.2.0-rc.2:refs/tags/dsh-v0.2.0-rc.2 - # One run covers everything: typecheck, all three vitest projects (host - # and client against src, compat against the BUILT plugin at each - # baseline tag), and the per-file coverage thresholds. + # `pnpm test` is the vitest run only: all three projects (host and client + # against src, compat against the BUILT plugin at each baseline tag) plus + # the per-file coverage thresholds. Typecheck is its own step above. - name: Test run: DSH_REPO="$PWD/.tmp/dsh-repo" pnpm test diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4266652..21e47a0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -45,6 +45,9 @@ jobs: - name: Lint run: pnpm run lint + - name: Typecheck + run: pnpm run typecheck + # The `compat` vitest project inside `pnpm test` stages the REAL harness # sources at every supported baseline tag (tests/baselines.ts is the # source of truth — keep this fetch list in step when a baseline is