Files
Lin Huazhong d8ebf2b893 test: one list of the agent folders a sandbox clears, so no sandbox misses an agent (yetone, on #522: A shared list of env vars for the other sandboxes would be a welcome follow-up) — every sandbox kept its own list of the variables that point at an agent's folder, and each had drifted: the gateway's cleared 5 of the 32 magpie reads, the provider package's 2, the tui's 10, the library's 20. A sandbox clearing 2 meets whatever Grok, Kimi, Hermes, MiniMax, Qoder or ZCode the developer has installed, which is how #522 came about — Qoder's two were in the library's list and in none of the four that failed. internal/agentenv is now the one list, and the 21 sandboxes that fake an environment with no agent in it clear it, each keeping beside it the variables that are not an agent's: APPDATA and LOCALAPPDATA, which a sandbox sets to a folder of its own rather than clearing, VISUAL and EDITOR. A name in the list is one magpie reads, and TestVarsAreRead walks the sources to say so, which is how two names a sandbox had been clearing turned out to be read by nothing at all — GEMINI_CLI_HOME and OPENCODE_CONFIG in internal/backup's, while OPENCODE_CONFIG_DIR, the one internal/agent reads (agents.go:545), was not in it. Where a sandbox set an agent's folder to a fixture of its own, the clearing now comes first, since a list of 32 wipes what a list of 5 left standing. Not converted: the omp tests' four variables, which are the ones omp's own lookup consults (a Pi fork) rather than every agent's, and the warm-up's Claude Code traffic flags, which are not folders — CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC stays out of the list for that reason too, its one test setting it on purpose. On Windows 11 the whole suite answers as it did before the change: 31 packages pass, and the same 15 tests in internal/library, internal/gateway and internal/agent fail for what they failed for before (symlinks this machine has no privilege for, and TestSuffixModesReachAgentFiles). go vet ./..., go build -tags nogui (windows, GOOS=linux, GOOS=darwin), and go vet -tags nogui for linux and darwin over every package touched pass. (#543)
2026-10-02 17:22:16 +08:00

68 lines
1.9 KiB
Go

package agentenv
import (
"io/fs"
"os"
"path/filepath"
"strings"
"testing"
)
// Every name in Vars is one magpie reads somewhere outside this package. A
// name it stopped reading, or one a sandbox invented, is a hole that every
// sandbox clearing this list believes is covered: internal/backup's cleared
// GEMINI_CLI_HOME and OPENCODE_CONFIG, which nothing reads, and not
// OPENCODE_CONFIG_DIR, which internal/agent does. This reads the sources
// rather than the agents' table, since the table is in internal/agent, which
// internal/sessions' tests cannot import; it looks for a quoted name, so a
// name only a comment mentions still counts, and a variable magpie reads
// through a name it builds at runtime would not.
func TestVarsAreRead(t *testing.T) {
found := make(map[string]bool, len(Vars))
err := filepath.WalkDir(filepath.Join("..", ".."), func(p string, d fs.DirEntry, err error) error {
if err != nil {
return err
}
if d.IsDir() {
switch d.Name() {
case ".git", "dist", "node_modules", "agentenv":
return fs.SkipDir
}
return nil
}
if !strings.HasSuffix(p, ".go") || strings.HasSuffix(p, "_test.go") {
return nil
}
b, err := os.ReadFile(p)
if err != nil {
return err
}
for _, v := range Vars {
if !found[v] && strings.Contains(string(b), `"`+v+`"`) {
found[v] = true
}
}
return nil
})
if err != nil {
t.Fatal(err)
}
for _, v := range Vars {
if !found[v] {
t.Errorf("%s is in Vars, but nothing outside this package reads it: magpie stopped reading it, or the name was never the one magpie reads", v)
}
}
}
// A name twice is a name a sandbox clears twice, which says the list was
// pasted together rather than kept.
func TestVarsAreApart(t *testing.T) {
seen := make(map[string]bool, len(Vars))
for _, v := range Vars {
if seen[v] {
t.Errorf("%s is in Vars twice", v)
}
seen[v] = true
}
}