Files
magpie/internal/gui/plugins_clash_test.go
yetone 2da8fbe488 tests: every test that runs plugins on the bun on PATH runs it once first, through testenv.Bun, so a bun that has never run here doesn't time out internal/provider's and internal/plugin's plugin tests (#1306)
65dcc573 (ggbdpq's patch 1) warmed the bun on PATH before the root
package's one-minute plugin contexts. The same lookup of the bun on PATH
is in 40 more places in internal/provider (28), internal/gateway (8),
internal/plugin (3) and internal/gui (1), and in the root package's
TestPluginListSaysClash. Many of them then open a one- or two-minute
context (internal/provider's sign-in, fetch and move tests,
internal/plugin's sandbox), and there macOS's first-exec check of a
just-installed or upgraded bun landed inside the deadline. The rest
are covered the same way, so no test has to remember which is which.

testenv.Bun now does what the root package's pathBun did: it finds the
bun on PATH (skipping the test when there is none) and runs
`bun --version` before the test opens its context, once per bun per test
binary. pathBun is gone; every `exec.LookPath("bun")` + skip block in
the tests uses testenv.Bun instead. Three tests reach for the bun some
other way and are left as they were: TestHostRunsAsMagpieBun (7ddea2c2
covers its copy), the plugin_git test's realBun and netproxy's
TestBunThroughBridge, none of which runs the plugin host under a
deadline on the PATH bun. migrate_test.go needed two `err` declarations
that the removed block used to provide.

What was run (macOS arm64, bun 1.4.2), with a wrapper bun first on PATH
whose first exec sleeps 61s (marker-gated, then execs the real bun):
- Red, old code:
  - internal/provider TestPluginSignInTakesAPastedCallback: FAIL at
    61.1s, "pluginsignin_paste_test.go:36: starting plugins: context
    deadline exceeded".
  - internal/plugin TestFakePlugin: FAIL at 62.0s, "plugin_test.go:66:
    Plugins = [], starting plugins: context deadline exceeded".
  - internal/gateway TestPluginFailover passed on the old code too (its
    calls have no deadline that short), so the gateway is not shown red.
- Green, this change, same cold wrapper: the three tests passed (61.1s,
  62.9s, 61.2s).
- go test -tags nogui -count=1 for the root package and for
  internal/testenv, gateway, gui, plugin and provider, under a temp HOME
  with GOMODCACHE, GOCACHE and GOPATH pinned: all ok.
- gofmt -l on the changed files: clean. go vet of those packages for
  darwin (-tags nogui), GOOS=linux and GOOS=windows (-tags nogui), and
  GOOS=windows without the tag: clean.

Not run: a really cold bun on a loaded machine; the sleep stands in for
the check. Not run on Linux or Windows, where the warm-up is one extra
`bun --version` per test binary.
2026-10-10 10:22:59 +08:00

97 lines
3.0 KiB
Go

package gui
import (
"bytes"
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"testing"
"github.com/yetone/magpie/internal/plugin"
"github.com/yetone/magpie/internal/testenv"
)
// Two installed plugins that sign in to one provider (neiko on Discord:
// a third-party plugin beside their own folder plugin): each row of
// /api/plugins carries the clash, naming the plugin that serves it and
// the provider as it is listed, and prefer hands it to the other one.
func TestPluginsClashRows(t *testing.T) {
bun := testenv.Bun(t)
dir := t.TempDir()
testenv.SetHome(t, dir)
t.Setenv("XDG_CONFIG_HOME", filepath.Join(dir, "config"))
t.Setenv("XDG_CACHE_HOME", filepath.Join(dir, "cache"))
t.Setenv("MAGPIE_BUN", bun)
t.Setenv("MAGPIE_PLUGIN_MARKET", "off")
t.Cleanup(plugin.Settle)
src, err := os.ReadFile("../plugin/testdata/fake/index.js")
if err != nil {
t.Fatal(err)
}
mine, theirs := filepath.Join(dir, "mine", "index.js"), filepath.Join(dir, "theirs", "index.js")
for _, f := range []string{mine, theirs} {
if err := os.MkdirAll(filepath.Dir(f), 0o755); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(f, src, 0o644); err != nil {
t.Fatal(err)
}
}
mux := http.NewServeMux()
pluginRoutes(mux, nil)
type row struct {
Spec string
Providers []string
Clashes []struct {
ID, By, Name string
With []string
}
}
do := func(path string, body any) map[string]row {
t.Helper()
method, rd := "GET", &bytes.Buffer{}
if body != nil {
method = "POST"
_ = json.NewEncoder(rd).Encode(body)
}
rec := httptest.NewRecorder()
mux.ServeHTTP(rec, httptest.NewRequest(method, path, rd))
if rec.Code != 200 {
t.Fatalf("%s: %d %s", path, rec.Code, rec.Body)
}
var s struct{ Plugins []row }
if err := json.Unmarshal(rec.Body.Bytes(), &s); err != nil {
t.Fatalf("%s: %v", path, err)
}
out := map[string]row{}
for _, r := range s.Plugins {
out[r.Spec] = r
}
return out
}
do("/api/plugins/add", map[string]string{"spec": mine})
rows := do("/api/plugins/add", map[string]string{"spec": theirs})
check := func(rows map[string]row, by string) {
t.Helper()
for spec, other := range map[string]string{mine: theirs, theirs: mine} {
r := rows[spec]
if len(r.Clashes) != 1 || r.Clashes[0].ID != "fakeco" || r.Clashes[0].By != by || r.Clashes[0].Name != "FakeCo" || len(r.Clashes[0].With) != 1 || r.Clashes[0].With[0] != other {
t.Fatalf("%s's row = %+v, want fakeco served by %s", spec, r, by)
}
if want := spec == by; (len(r.Providers) == 1) != want {
t.Fatalf("%s's row lists %v; serving fakeco: %v", spec, r.Providers, want)
}
}
}
check(rows, theirs)
check(do("/api/plugins/prefer", map[string]string{"spec": mine, "provider": "fakeco"}), mine)
check(do("/api/plugins", nil), mine)
// removing theirs leaves mine alone, and no clash to say
rows = do("/api/plugins/remove", map[string]string{"spec": theirs})
if r, ok := rows[mine]; !ok || len(r.Clashes) != 0 || len(r.Providers) != 1 || len(rows) != 1 {
t.Fatalf("after removing theirs, rows = %+v", rows)
}
}