yetone
06420a7121
macOS checks a newly written executable before its first exec: 0.27s alone, 2-5s while other new programs start (a go test ./... starting its test binaries). The same file again takes 0.009s, and the pass is kept across a rename and an in-place rewrite.108852b4worked round this for one test with /bin/sh -c; the class was every test that writes a `#!/bin/sh` fake and times its answer. testenv.Program(t, path, script) replaces os.WriteFile(path, script, 0o755) for fakes. On macOS it renames a file that has run once from a pool to path and writes the script into it in place; at the test's cleanup the file goes back to the pool (only a path the test created; a stand-in it wrote over stays). Fakes still end with their tests: nothing about how they are started or waited on changed. Run (and gateway's TestMain) remove the pool at the end. TestMain's PATH stand-ins are run once in the background (testenv.StandIns). Other systems write the file as before. Converted every `#!/bin/sh` fake written by tests under internal/ (agent, gateway, gui, library, plugin, proc, provider, update). Windows, binary and node/bun fakes are unchanged. Under the same load (3 loops each starting 8 freshly written scripts at a time), 4 rounds each, before (108852b4/ origin/main) vs after: - provider TestSavedButSignedOutClaudeServed: 4/4 fail (8.01s) -> 4/4 pass - provider TestClaudeSignInOverStaleCredentials: 4/4 fail (5.00s) -> 4/4 pass - provider TestDevinSignedInOnlyInMagpie: 3/4 fail ("CLI's own []") -> 4/4 pass - gateway TestClaudeRunEndsWhenTheClientLeaves: 4/4 fail -> 4/4 pass (and 3/3 fail -> 3/3 pass at a third of that load) - gateway TestClientGoneRecordedAsCanceled: 4/4 fail -> 4/4 pass - gui TestProvidersAnswerWhileListsComeIn ("cursor found false" at 3.03s): 4/4 fail -> 4/4 pass. The same class, not bfe8bcaf's test order. - proc TestUserPath (login shell's PATH never came, 7.01s): 4/4 fail -> 4/4 pass Unloaded, every touched package passes; no pool directory or process is left after a run.
88 lines
2.7 KiB
Go
88 lines
2.7 KiB
Go
package gui
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/yetone/magpie/internal/testenv"
|
|
)
|
|
|
|
func TestRegisterScheme(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
name string
|
|
flatpak bool
|
|
existing bool
|
|
}{
|
|
{"flatpak without entry", true, false},
|
|
{"flatpak with entry", true, true},
|
|
{"native without entry", false, false},
|
|
{"native with entry", false, true},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Setenv("FLATPAK_ID", "")
|
|
if tc.flatpak {
|
|
t.Setenv("FLATPAK_ID", "ai.usemagpie.Magpie")
|
|
}
|
|
root := t.TempDir()
|
|
data := filepath.Join(root, "data")
|
|
t.Setenv("XDG_DATA_HOME", data)
|
|
bin := filepath.Join(root, "bin")
|
|
if err := os.Mkdir(bin, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
calls := filepath.Join(root, "calls")
|
|
t.Setenv("MAGPIE_SCHEME_TEST_CALLS", calls)
|
|
t.Setenv("PATH", bin)
|
|
for _, name := range []string{"update-desktop-database", "xdg-mime"} {
|
|
script := "#!/bin/sh\nprintf '%s\\n' '" + name + "' \"$@\" >> \"$MAGPIE_SCHEME_TEST_CALLS\"\n"
|
|
testenv.Program(t, filepath.Join(bin, name), script)
|
|
}
|
|
dir := filepath.Join(data, "applications")
|
|
path := filepath.Join(dir, "magpie.desktop")
|
|
const old = "[Desktop Entry]\nExec=/usr/bin/magpie %u\nMimeType=x-scheme-handler/magpie;\n"
|
|
if tc.existing {
|
|
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(path, []byte(old), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
if err := registerScheme(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if tc.flatpak {
|
|
if tc.existing {
|
|
if got, err := os.ReadFile(path); err != nil || string(got) != old {
|
|
t.Fatalf("existing desktop entry changed: %q, %v", got, err)
|
|
}
|
|
} else if _, err := os.Stat(dir); !os.IsNotExist(err) {
|
|
t.Fatalf("applications directory was created: %v", err)
|
|
}
|
|
if got, err := os.ReadFile(calls); !os.IsNotExist(err) {
|
|
t.Fatalf("desktop registration ran: %q, %v", got, err)
|
|
}
|
|
return
|
|
}
|
|
exe, err := os.Executable()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, err := os.ReadFile(path)
|
|
if err != nil || !strings.Contains(string(got), "Exec="+exe+" %u\n") || !strings.Contains(string(got), "MimeType=x-scheme-handler/magpie;\n") {
|
|
t.Fatalf("desktop entry: %q, %v", got, err)
|
|
}
|
|
// An entry for this executable is already registered on the next run.
|
|
if err := registerScheme(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
want := "update-desktop-database\n" + dir + "\nxdg-mime\ndefault\nmagpie.desktop\nx-scheme-handler/magpie\n"
|
|
if got, err := os.ReadFile(calls); err != nil || string(got) != want {
|
|
t.Fatalf("registration calls: %q, want %q (%v)", got, want, err)
|
|
}
|
|
})
|
|
}
|
|
}
|