yetone
06420a7121
macOS checks a newly written executable before its first exec: 0.27s alone, 2-5s while other new programs start (a go test ./... starting its test binaries). The same file again takes 0.009s, and the pass is kept across a rename and an in-place rewrite.108852b4worked round this for one test with /bin/sh -c; the class was every test that writes a `#!/bin/sh` fake and times its answer. testenv.Program(t, path, script) replaces os.WriteFile(path, script, 0o755) for fakes. On macOS it renames a file that has run once from a pool to path and writes the script into it in place; at the test's cleanup the file goes back to the pool (only a path the test created; a stand-in it wrote over stays). Fakes still end with their tests: nothing about how they are started or waited on changed. Run (and gateway's TestMain) remove the pool at the end. TestMain's PATH stand-ins are run once in the background (testenv.StandIns). Other systems write the file as before. Converted every `#!/bin/sh` fake written by tests under internal/ (agent, gateway, gui, library, plugin, proc, provider, update). Windows, binary and node/bun fakes are unchanged. Under the same load (3 loops each starting 8 freshly written scripts at a time), 4 rounds each, before (108852b4/ origin/main) vs after: - provider TestSavedButSignedOutClaudeServed: 4/4 fail (8.01s) -> 4/4 pass - provider TestClaudeSignInOverStaleCredentials: 4/4 fail (5.00s) -> 4/4 pass - provider TestDevinSignedInOnlyInMagpie: 3/4 fail ("CLI's own []") -> 4/4 pass - gateway TestClaudeRunEndsWhenTheClientLeaves: 4/4 fail -> 4/4 pass (and 3/3 fail -> 3/3 pass at a third of that load) - gateway TestClientGoneRecordedAsCanceled: 4/4 fail -> 4/4 pass - gui TestProvidersAnswerWhileListsComeIn ("cursor found false" at 3.03s): 4/4 fail -> 4/4 pass. The same class, not bfe8bcaf's test order. - proc TestUserPath (login shell's PATH never came, 7.01s): 4/4 fail -> 4/4 pass Unloaded, every touched package passes; no pool directory or process is left after a run.
66 lines
2.3 KiB
Go
66 lines
2.3 KiB
Go
//go:build !windows
|
|
|
|
package library
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/yetone/magpie/internal/testenv"
|
|
)
|
|
|
|
// TestRTKOffPath (#601): an rtk magpie finds where rtk's script puts it,
|
|
// ~/.local/bin, which the app adds to its own PATH but the user's shell
|
|
// may not have, isn't one the agents' hooks can run — Pi's turns itself
|
|
// off with "rtk binary not found in PATH". The page says so instead of
|
|
// showing RTK working, and Put RTK on PATH links it into a folder on it.
|
|
func TestRTKOffPath(t *testing.T) {
|
|
h := sandbox(t)
|
|
local := filepath.Join(h, ".local", "bin")
|
|
testenv.Program(t, filepath.Join(local, "rtk"), fakeRTK)
|
|
tools := filepath.Join(h, "tools")
|
|
testenv.Program(t, filepath.Join(tools, "curl"), "#!/bin/sh\n")
|
|
t.Setenv("PATH", tools)
|
|
|
|
v := ReadRTK()
|
|
if v.Path != filepath.Join(local, "rtk") || !v.OffPath {
|
|
t.Fatalf("rtk at %q, off PATH %v; want it found in ~/.local/bin and said to be off PATH", v.Path, v.OffPath)
|
|
}
|
|
if v.PathDir != "" {
|
|
t.Fatalf("no folder on PATH rtk can go in, yet PathDir is %q", v.PathDir)
|
|
}
|
|
if _, err := PathRTK(); err == nil || !strings.Contains(err.Error(), local) {
|
|
t.Fatalf("PathRTK with nowhere to put rtk: %v; want it to say to add %s to PATH", err, local)
|
|
}
|
|
if _, err := SetRTK("claude", true); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// ~/bin is on the shell's PATH: rtk is linked in there
|
|
userBin := filepath.Join(h, "bin")
|
|
t.Setenv("PATH", tools+string(os.PathListSeparator)+userBin)
|
|
if v = ReadRTK(); !v.OffPath || v.PathDir != userBin || !v.PathLink {
|
|
t.Fatalf("off PATH %v, PathDir %q, link %v; want %s linked into", v.OffPath, v.PathDir, v.PathLink, userBin)
|
|
}
|
|
v, err := PathRTK()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if v.OffPath || !slices.Contains(v.Restart, "claude") {
|
|
t.Fatalf("after PathRTK: off PATH %v, restart %v", v.OffPath, v.Restart)
|
|
}
|
|
if to, err := os.Readlink(filepath.Join(userBin, "rtk")); err != nil || to != filepath.Join(local, "rtk") {
|
|
t.Fatalf("~/bin/rtk links to %q (%v)", to, err)
|
|
}
|
|
// upgraded with its script into ~/.local/bin, where the link points,
|
|
// not over the link
|
|
c := rtkUpgrader(filepath.Join(userBin, "rtk"))
|
|
real, _ := filepath.EvalSymlinks(local)
|
|
if len(c) != 4 || c[3] != real {
|
|
t.Fatalf("upgrade through the link: %q; want rtk's script into %s", c, real)
|
|
}
|
|
}
|