Files
yetone 7ddea2c2e0 plugin tests: TestHostRunsAsMagpieBun puts the Bun on PATH at the old name as a hard link, not a fresh copy, so macOS's first-run check of a new program no longer comes out of the host's one-minute start under a full go test run (#1306)
A copy is a new program, which macOS checks before its first exec; the
host's init ran it inside the test's minute. Timed here with load ~130
and syspolicyd not pegged: a fresh copy's first `--version` took
0.9-1.6s, a hard link of the same bun 0.04-0.3s; with syspolicyd busy
the same check took 26-55s a program in #1284. Where no link can be
made (another filesystem), the copy is run once before the minute starts.

Run in Docker (golang:1.26.8, linux/arm64, bun 1.4.2): -count=3 of the
test with bun on a bind mount (copy path) and beside HOME (link path),
all PASS; go test -tags nogui ./internal/plugin ok; go vet for linux,
windows and darwin clean. Not run: the test on macOS itself (Go tests
are kept off this Mac while syspolicyd is overloaded), so the red under
a slow first-run check is shown by the timings above, not by a failing run.
2026-10-09 01:02:51 +08:00

141 lines
4.1 KiB
Go

package plugin
import (
"context"
"io"
"os"
"os/exec"
"path/filepath"
"runtime"
"strconv"
"strings"
"testing"
"time"
)
// The Bun magpie downloads is kept as magpie-bun, the name a proxy app's
// PROCESS-NAME rule sees (#1048).
func TestBunDownloadedAsMagpieBun(t *testing.T) {
bunHome(t, BunVersion, time.Now())
asked := bunReleases(t, []byte("bun"))
exe, err := Bun(context.Background())
if err != nil {
t.Fatal(err)
}
if filepath.Base(exe) != magpieBun() || asked.Load() != 1 {
t.Fatalf("Bun = %s after %d downloads, want one named %s", exe, asked.Load(), magpieBun())
}
if _, err := os.Stat(filepath.Join(filepath.Dir(exe), bunExe())); !os.IsNotExist(err) {
t.Fatalf("a bun beside magpie-bun: %v", err)
}
}
// A Bun downloaded before is renamed magpie-bun, not downloaded again.
func TestBunDownloadedBeforeTakesTheName(t *testing.T) {
bunHome(t, BunVersion, time.Now())
asked := bunReleases(t, []byte("new download"))
old := filepath.Join(bunDirOf(BunVersion), bunExe())
if err := os.MkdirAll(filepath.Dir(old), 0o755); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(old, []byte("downloaded before"), 0o755); err != nil {
t.Fatal(err)
}
if !HasBun() {
t.Fatal("HasBun is false with a bun downloaded before")
}
exe, err := Bun(context.Background())
if err != nil {
t.Fatal(err)
}
if b, _ := os.ReadFile(exe); filepath.Base(exe) != magpieBun() || string(b) != "downloaded before" || asked.Load() != 0 {
t.Fatalf("Bun = %s holding %q after %d downloads", exe, b, asked.Load())
}
if _, err := os.Stat(old); !os.IsNotExist(err) {
t.Fatalf("the old bun is still there: %v", err)
}
}
// The plugin host runs as magpie-bun: the process name the system reports
// for it is magpie-bun, not bun.
func TestHostRunsAsMagpieBun(t *testing.T) {
real, err := exec.LookPath("bun")
if err != nil {
t.Skip("no bun on PATH")
}
bunHome(t, BunVersion, time.Now())
t.Cleanup(Settle)
// a real Bun as magpie downloaded it before, at the old name: a hard
// link, not a symlink (whose process would take the target's name)
old := filepath.Join(bunDirOf(BunVersion), bunExe())
if err := os.MkdirAll(filepath.Dir(old), 0o755); err != nil {
t.Fatal(err)
}
placeBun(t, real, old)
ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
defer cancel()
abs, _ := filepath.Abs("testdata/fake/index.js")
if _, err := Add(ctx, abs); err != nil {
t.Fatal(err)
}
if ps, err := Providers(ctx); err != nil || len(ps) != 1 {
t.Fatalf("Providers = %+v, %v", ps, err)
}
hostMu.Lock()
h := current
hostMu.Unlock()
if h == nil || h.cmd.Process == nil {
t.Fatal("no host running")
}
if got := filepath.Base(h.cmd.Path); got != magpieBun() {
t.Fatalf("the host runs %s", h.cmd.Path)
}
if runtime.GOOS == "windows" {
return
}
out, err := exec.Command("ps", "-o", "comm=", "-p", strconv.Itoa(h.cmd.Process.Pid)).Output()
if err != nil {
t.Fatal(err)
}
if got := filepath.Base(strings.TrimSpace(string(out))); got != "magpie-bun" {
t.Fatalf("ps says the host is %q", got)
}
}
// placeBun puts the Bun at from at to, as a file that has run before. A
// hard link is the Bun on PATH itself, which has. A copy is a new program,
// and macOS checks a new program before its first run: a second alone,
// tens of seconds while a go test ./... starts its test binaries, which
// came out of the host's start and its minute (#1306). So a copy, where
// no link can be made, is run once here, before that minute starts.
func placeBun(t *testing.T, from, to string) {
t.Helper()
if src, err := filepath.EvalSymlinks(from); err == nil && os.Link(src, to) == nil {
return
}
copyExe(t, from, to)
if out, err := exec.Command(to, "--version").CombinedOutput(); err != nil {
t.Fatalf("the copied bun: %v %s", err, out)
}
}
func copyExe(t *testing.T, from, to string) {
t.Helper()
in, err := os.Open(from)
if err != nil {
t.Fatal(err)
}
defer in.Close()
out, err := os.OpenFile(to, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o755)
if err != nil {
t.Fatal(err)
}
if _, err := io.Copy(out, in); err != nil {
t.Fatal(err)
}
if err := out.Close(); err != nil {
t.Fatal(err)
}
}