Files
magpie/omp_cli_test.go
T
cyxer000 abbffd73a4 agents: magpie omp auto sets omp's thinking to auto, and the panel's effort slider shows a level it doesn't list as it is (#339)
* agents: `magpie omp auto` sets omp's thinking to auto, and the panel's effort slider shows a level it doesn't list as it is

omp keeps defaultThinkingLevel at minimal … max or auto (omp picks a
level each turn), but magpie offered only the six levels. So
`magpie omp auto` found no field offering auto and took it for a model:
modelRoles.default became the literal "auto". auto is now offered
first, as omp's own picker has it, and kept out of ompEfforts, which a
model's thinking levels in models.yml are filtered by.

The tray panel's effort slider drew a value that isn't one of its
options (an agent with no effort set, a level magpie doesn't list) at
the first stop, named as the lowest level, and a touch there wrote that
level over it. It now gets a stop of its own, as the window's picker
gives the current value, so it reads as it is and a touch leaves it.

* agents: the note on omp's thinking picker holds for omp 16.3.5 too

omp 16.3.5 takes auto for defaultThinkingLevel as 18.4.4 does (config/settings-schema.ts there), as checked on #339.
2026-10-01 00:20:19 +08:00

47 lines
1.4 KiB
Go

package main
import (
"os"
"path/filepath"
"testing"
"github.com/yetone/magpie/internal/agent"
"gopkg.in/yaml.v3"
)
// `magpie omp auto` asks for omp's own thinking level, auto (omp picks one
// each turn), and so goes to the thinking field: taken as a model, it made
// modelRoles.default the literal "auto", which omp has no model by.
func TestOmpAutoIsAThinkingLevel(t *testing.T) {
groupsHome(t)
for _, k := range []string{"PI_CODING_AGENT_DIR", "PI_CONFIG_DIR", "OMP_PROFILE", "PI_PROFILE"} {
t.Setenv(k, "")
}
dir := filepath.Join(os.Getenv("HOME"), ".omp", "agent")
os.MkdirAll(dir, 0o755)
config := filepath.Join(dir, "config.yml")
os.WriteFile(config, []byte("modelRoles:\n default: anthropic/claude-opus-5-5:max\ndefaultThinkingLevel: high\n"), 0o644)
a, err := agent.Find("omp")
if err != nil {
t.Fatal(err)
}
f := fieldForValue(a, "auto")
if f == nil || f.Key != "effort" {
t.Fatalf("auto went to %v, not the thinking level", f)
}
if err := set(a, f.Key, "auto"); err != nil {
t.Fatal(err)
}
b, _ := os.ReadFile(config)
var c struct {
ModelRoles map[string]string `yaml:"modelRoles"`
DefaultThinkingLevel string `yaml:"defaultThinkingLevel"`
}
if err := yaml.Unmarshal(b, &c); err != nil {
t.Fatal(err)
}
if c.DefaultThinkingLevel != "auto" || c.ModelRoles["default"] != "anthropic/claude-opus-5-5:max" {
t.Fatalf("config:\n%s", b)
}
}