Files
magpie/internal/update/cli_path_windows.go
T
yetone d6daa40ce3 update, gui: Settings › About › Command line says what magpie runs in a new terminal and adds it (PAMI on Discord) — the app downloaded from the site, and every Windows one, left terminals without the magpie command, and nothing in the GUI said whether it was there. A Command line row now asks each shell installed (zsh, bash, fish and the login shell; PowerShell and cmd on Windows) for its PATH and says, with a dot each, whether its magpie runs this app, another copy (with that copy's version, read from its .app's Info.plist or Homebrew Cellar folder, never by running it), or none. Add to PATH links this app's program (Homebrew's opt link, the AppImage) into the folder on the default shell's PATH whose magpie runs first, else ~/.local/bin or the like when on PATH, replacing another copy there as install.sh's ln -sf does; on Windows it puts the app's folder first in HKCU\Environment Path and broadcasts WM_SETTINGCHANGE. A shell whose PATH lacks that folder gets its own button naming its profile (~/.zshrc, ~/.bash_profile on the Mac or ~/.bashrc, fish's config.fish), which links into ~/.local/bin and adds that folder with one marked line, once; no profile is written otherwise. A translocated or disk-image app is told to move first and gets no button. It says new terminals take the change (on Windows: new PowerShell/cmd windows, restart Windows Terminal). GET/POST /api/cli; en/zh/ja/de. TestCLIOnPath (temp HOME, stubbed shells: link, fish profile once, a shadowing copy replaced, no folder → zsh's profile kept and appended, an unknown shell refused, plist version, translocated refused) and TestPathFirst are new; cli-path.test.cjs (WebKit, en and zh: per-shell dots, Add posts {} and turns green, fish's button posts fish alone, Windows lists PowerShell and cmd, translocated gets no button, no scroll, no select, no left border, translations) fails without the change; cli-behind and update-auto pass. Not tried on a real Windows machine. go vet, go build (darwin, GOOS=linux nogui, GOOS=windows) and go test -tags nogui ./... under a temp HOME pass (TestOTelWholeWaterfallFallback and TestDevinSignedInOnlyInMagpie failed once each under load and pass alone).
2026-10-05 17:49:20 +08:00

63 lines
1.9 KiB
Go

package update
import (
"fmt"
"os"
"path/filepath"
ptr "unsafe"
"golang.org/x/sys/windows"
"golang.org/x/sys/windows/registry"
)
// installedShells are PowerShell and cmd, which both take the registry's
// PATH (proc.ShellPath).
func installedShells() []cliShell {
return []cliShell{{Name: "PowerShell", Default: true}, {Name: "cmd"}}
}
// cliDir is the app's own folder, put first in the user's PATH: a link
// needs Developer Mode or an administrator, and a copy wouldn't follow
// the app's updates.
func cliDir(exe string, _ []string, _ string) string { return filepath.Dir(exe) }
// cliPlace puts dir first in the user's PATH in the registry, where a
// terminal opened from now on takes it up, and tells Explorer.
func cliPlace(_, dir string) error {
k, err := registry.OpenKey(registry.CURRENT_USER, `Environment`, registry.QUERY_VALUE|registry.SET_VALUE)
if err != nil {
return err
}
defer k.Close()
v, typ, err := k.GetStringValue("Path")
if err != nil && err != registry.ErrNotExist {
return err
}
nv := pathFirst(v, dir)
if nv == v {
return nil
}
// kept REG_EXPAND_SZ, as Windows has it, so %USERPROFILE% in it still works
if err == registry.ErrNotExist || typ == registry.EXPAND_SZ {
err = k.SetExpandStringValue("Path", nv)
} else {
err = k.SetStringValue("Path", nv)
}
if err != nil {
return fmt.Errorf("adding %s to your PATH: %w", dir, err)
}
os.Setenv("PATH", dir+";"+os.Getenv("PATH"))
settingChanged()
return nil
}
// settingChanged tells Explorer the environment changed, so what it starts
// next — a terminal from the Start menu — has the new PATH.
func settingChanged() {
const hwndBroadcast, wmSettingChange, smtoAbortIfHung = 0xffff, 0x001A, 0x0002
env, _ := windows.UTF16PtrFromString("Environment")
var res uintptr
windows.NewLazySystemDLL("user32.dll").NewProc("SendMessageTimeoutW").Call(
hwndBroadcast, wmSettingChange, 0, uintptr(ptr.Pointer(env)), smtoAbortIfHung, 5000, uintptr(ptr.Pointer(&res)))
}