Files
magpie/internal/gui/tests/model-pick.test.cjs
T
yetone 6d69272732 agents: a model picked for Claude Code (or any agent) shows on its row at once, in the window and the tray panel, and /api/set answers in ~0.1s instead of seconds (Discord: switching Claude Code's model took 5–10s to show, magpie 0.1.410+) — /api/set writes the config and answers with the whole state, and the frontend drew the pick only from that answer. Every state asked the devin CLI (devin models list, ~1.5–3s a run) again several times whenever Devin was installed: its model's family, its options, its effort's options and Drift's re-read, and a CLI that gave no list (signed out, offline) was asked anew on every state, since only a list was cached. With a 4s CLI one set took 28s (measured, before). Now DevinFamilies keeps a failure for a minute, serves a list past its 5 minutes while it is read again in the background, and only a caller with nothing known waits — never one marked DevinNoWait, which Devin's field reads and options are (its Set still waits, so what is written is unchanged). Goose's detection read a binary's whole build info on every state (~150ms); the answer is kept while the file's size and time are the same. In the page, commit() draws the picked model and its flash before /api/set is sent, then draws the answer (a later pick's answer winning over an earlier one's); a refused pick puts the old model back and gives the reason. What is written to the agent's config is as before. Measured in a sandbox HOME with magpie web: /api/state 2.8–3.1s and /api/set 2.9s before, 0.1–0.5s after (state() ~110ms steady in-process); a provider whose endpoint never answers made no difference either way. Tested with internal/gui/set_fast_unix_test.go (devin CLI that sleeps 4s and a provider that never answers: three sets and the states after them each under 1.5s, ~5ms, settings.json as before; fails before the fix at 28s a set) and internal/gui/tests/model-pick.test.cjs (a set held 2.5s: the pick shown within 600ms in the window scrolled and in the tray panel's opened row and line, the page not moved, the answer keeping it, a refusal restoring the old model, en and zh, Chromium and WebKit; fails on main). click-scroll, panel-fold, menu-scroll, agy-launch, cli-update and old-webkit pass. go build -tags nogui (and GOOS=linux, GOOS=windows), go vet and go test -tags nogui ./... pass (TestClaudeAccountNamedAsItsLogin failed under load and passes alone). Not tried in the real Wails window or tray, nor with a real signed-in Devin CLI.
2026-09-30 03:21:24 +08:00

141 lines
8.0 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
// Run with Node's test runner and Playwright on the module path; see README.md.
// A model picked for an agent shows on its row at once, while /api/set is
// still out (it answers with the whole state, which took seconds: Claude
// Code's model took 5–10s to show, in the window and the tray panel alike).
// The answer then draws what the config says; a refused pick puts the old
// model back and says why. The page never moves. In English and Chinese.
// No backend: the API is faked here, its /api/set held for SLOW ms.
const assert = require("node:assert/strict");
const fs = require("node:fs/promises");
const path = require("node:path");
const { test } = require("node:test");
const { chromium, webkit } = require("playwright");
const assets = path.resolve(__dirname, "../assets");
const SLOW = 2500;
const models = ["claude-sonnet-5-5", "claude-opus-5-5", "magpie/deepseek/pro", "magpie/kimi/k3"].map((m) => ({ value: m, label: "Label " + m }));
const agent = (id, name) => ({
id, name, path: "/test/" + id,
fields: [{ key: "model", label: "model", value: "claude-sonnet-5-5", options: models }],
});
const fresh = () => ({
// Claude Code down the list, so it is picked with the list scrolled
agents: [...Array.from({ length: 5 }, (_, i) => agent("agent-" + i, "Agent " + i)), agent("claude", "Claude Code"),
...Array.from({ length: 8 }, (_, i) => agent("more-" + i, "More " + i))],
profiles: [],
});
function server(lang, sets, refuse) {
let cur = fresh();
return async (route) => {
const req = route.request(), url = new URL(req.url());
if (url.pathname === "/boot.js") return route.fulfill({ contentType: "text/javascript", body: `window.bootPrefs = {lang:"${lang}",theme:"light",web:true};` });
if (url.pathname === "/wails/runtime.js") return route.fulfill({ contentType: "text/javascript", body: "export const Window = {};" });
if (url.pathname === "/api/state") return route.fulfill({ json: { ...cur, settings: { lang, theme: "light" } } });
if (url.pathname === "/api/set") {
const body = req.postDataJSON();
sets.push(body);
await new Promise((r) => setTimeout(r, SLOW));
if (refuse) return route.fulfill({ status: 400, json: { error: "Claude Code's settings.json is not valid JSON" } });
cur = JSON.parse(JSON.stringify(cur));
cur.agents.find((a) => a.id === body.agent).fields.find((f) => f.key === body.field).value = body.value;
return route.fulfill({ json: { ...cur, settings: { lang, theme: "light" } } }).catch(() => {});
}
if (url.pathname === "/api/usage/quotas") return route.fulfill({ json: [] });
if (url.pathname === "/api/groups") return route.fulfill({ json: { groups: [] } });
if (url.pathname === "/api/agents/cli") return route.fulfill({ json: { agents: {}, pending: false } });
if (url.pathname === "/api/providers") return route.fulfill({ json: { providers: [], gateway: { running: true } } });
if (url.pathname.startsWith("/api/")) return route.fulfill({ json: {} });
const file = path.join(assets, url.pathname === "/" ? "index.html" : url.pathname);
const contentType = { ".html": "text/html", ".js": "text/javascript", ".css": "text/css", ".svg": "image/svg+xml", ".png": "image/png" }[path.extname(file)];
await route.fulfill({ body: await fs.readFile(file), contentType });
};
}
const row = '.row.agent[data-id="claude"]';
for (const engine of (process.env.BROWSER ? [process.env.BROWSER] : ["chromium", "webkit"])) {
test(engine + ": a picked model shows at once", async (t) => {
assert(["chromium", "webkit"].includes(engine), "BROWSER must be chromium or webkit");
const browser = await (engine === "webkit" ? webkit.launch() : chromium.launch({ channel: "chromium" }));
const errors = [];
t.after(async () => {
if (errors.length) console.log(errors);
await browser.close();
});
const open = async (url, lang, sets, { refuse = false, viewport = { width: 980, height: 420 } } = {}) => {
const page = await (await browser.newContext({ viewport })).newPage();
page.setDefaultTimeout(5000);
page.on("pageerror", (e) => errors.push(e.message));
await page.route("**/*", server(lang, sets, refuse));
await page.goto(url);
await page.locator(row).waitFor();
return page;
};
// the picker's row for a model, clicked
const pickModel = async (page, value) => {
const li = page.locator("#list li").filter({ hasText: "Label " + value });
await li.first().click();
return Date.now();
};
for (const lang of ["en", "zh"]) {
await t.test(lang + ": the window", async () => {
const sets = [];
const page = await open("http://magpie.test/", lang, sets);
const view = page.locator("#view-agents");
const field = page.locator(`${row} .field[data-key="model"]`);
await page.mouse.move(400, 300);
for (let i = 0; i < 2; i++) { await page.mouse.wheel(0, 30); await page.waitForTimeout(20); }
await page.waitForTimeout(300);
const top = await view.evaluate((v) => v.scrollTop);
assert(top > 0, "the list must be scrolled");
await field.click();
await page.locator("#pop:not([hidden]) #list li").first().waitFor();
const at = await pickModel(page, "magpie/deepseek/pro");
await page.waitForFunction((r) => document.querySelector(r + ' .field[data-key="model"] .v')?.textContent === "Label magpie/deepseek/pro", row, { timeout: 600 });
assert(Date.now() - at < SLOW, "shown before the answer came");
assert.equal(sets.length, 1);
assert.deepEqual(sets[0], { agent: "claude", field: "model", value: "magpie/deepseek/pro" });
assert.equal(await view.evaluate((v) => v.scrollTop), top, "the pick moved the page");
// the answer, drawn, keeps it
await page.waitForTimeout(SLOW + 300);
assert.equal(await field.locator(".v").textContent(), "Label magpie/deepseek/pro");
assert.match(await page.locator("#status").textContent(), /Claude Code .*Label magpie\/deepseek\/pro/);
assert.equal(await view.evaluate((v) => v.scrollTop), top, "the answer moved the page");
});
}
await t.test("the tray panel: in the opened row and its line", async () => {
const sets = [];
const page = await open("http://magpie.test/?mode=panel", "en", sets, { viewport: { width: 440, height: 560 } });
await page.locator(`${row} .ag-sum`).click();
await page.waitForTimeout(700);
await page.locator(`${row} .ag-open .field[data-key="model"]`).click();
await page.locator("#pop:not([hidden]) #list li").first().waitFor();
const at = await pickModel(page, "magpie/kimi/k3");
await page.waitForFunction((r) => document.querySelector(r + " .ag-sum .vt")?.textContent === "Label magpie/kimi/k3", row, { timeout: 600 });
assert(Date.now() - at < SLOW, "shown before the answer came");
assert.equal(await page.locator(`${row} .ag-open .field[data-key="model"] .v`).textContent(), "Label magpie/kimi/k3");
assert.equal(await page.locator(`${row}.open`).count(), 1, "the row stays open");
await page.waitForTimeout(SLOW + 300);
assert.equal(await page.locator(`${row} .ag-sum .vt`).textContent(), "Label magpie/kimi/k3");
assert.equal(sets.length, 1);
});
await t.test("a refused pick puts the old model back", async () => {
const sets = [];
const page = await open("http://magpie.test/", "en", sets, { refuse: true });
const field = page.locator(`${row} .field[data-key="model"]`);
await field.click();
await page.locator("#pop:not([hidden]) #list li").first().waitFor();
await pickModel(page, "claude-opus-5-5");
await page.waitForFunction((r) => document.querySelector(r + ' .field[data-key="model"] .v')?.textContent === "Label claude-opus-5-5", row, { timeout: 600 });
await page.waitForFunction((r) => document.querySelector(r + ' .field[data-key="model"] .v')?.textContent === "Label claude-sonnet-5-5", row, { timeout: SLOW + 2000 });
assert.match(await page.locator("#status").textContent(), /not valid JSON/);
});
assert.deepEqual(errors, []);
});
}