Files
magpie/webdav_cli_test.go
T
Lin Huazhong d8ebf2b893 test: one list of the agent folders a sandbox clears, so no sandbox misses an agent (yetone, on #522: A shared list of env vars for the other sandboxes would be a welcome follow-up) — every sandbox kept its own list of the variables that point at an agent's folder, and each had drifted: the gateway's cleared 5 of the 32 magpie reads, the provider package's 2, the tui's 10, the library's 20. A sandbox clearing 2 meets whatever Grok, Kimi, Hermes, MiniMax, Qoder or ZCode the developer has installed, which is how #522 came about — Qoder's two were in the library's list and in none of the four that failed. internal/agentenv is now the one list, and the 21 sandboxes that fake an environment with no agent in it clear it, each keeping beside it the variables that are not an agent's: APPDATA and LOCALAPPDATA, which a sandbox sets to a folder of its own rather than clearing, VISUAL and EDITOR. A name in the list is one magpie reads, and TestVarsAreRead walks the sources to say so, which is how two names a sandbox had been clearing turned out to be read by nothing at all — GEMINI_CLI_HOME and OPENCODE_CONFIG in internal/backup's, while OPENCODE_CONFIG_DIR, the one internal/agent reads (agents.go:545), was not in it. Where a sandbox set an agent's folder to a fixture of its own, the clearing now comes first, since a list of 32 wipes what a list of 5 left standing. Not converted: the omp tests' four variables, which are the ones omp's own lookup consults (a Pi fork) rather than every agent's, and the warm-up's Claude Code traffic flags, which are not folders — CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC stays out of the list for that reason too, its one test setting it on purpose. On Windows 11 the whole suite answers as it did before the change: 31 packages pass, and the same 15 tests in internal/library, internal/gateway and internal/agent fail for what they failed for before (symlinks this machine has no privilege for, and TestSuffixModesReachAgentFiles). go vet ./..., go build -tags nogui (windows, GOOS=linux, GOOS=darwin), and go vet -tags nogui for linux and darwin over every package touched pass. (#543)
2026-10-02 17:22:16 +08:00

229 lines
6.6 KiB
Go

package main
import (
"bufio"
"io"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"slices"
"strings"
"sync"
"testing"
"github.com/yetone/magpie/internal/agentenv"
"github.com/yetone/magpie/internal/davsync"
"github.com/yetone/magpie/internal/provider"
)
// webdavHome is a machine of its own: no agent on it, no gateway at the
// address, and nothing on stdin.
func webdavHome(t *testing.T) {
t.Helper()
home := t.TempDir()
t.Setenv("HOME", home)
t.Setenv("USERPROFILE", home)
t.Setenv("XDG_CONFIG_HOME", filepath.Join(home, ".config"))
t.Setenv("XDG_CACHE_HOME", filepath.Join(home, ".cache"))
t.Setenv("PATH", "")
for _, v := range agentenv.Vars {
t.Setenv(v, "")
}
t.Setenv("APPDATA", "")
t.Setenv("LOCALAPPDATA", "")
t.Setenv("CLAUDE_CONFIG_DIR", filepath.Join(home, ".claude"))
t.Setenv("CODEX_HOME", filepath.Join(home, ".codex"))
t.Setenv("MAGPIE_ADDR", "127.0.0.1:1")
piped(t)
}
// davServer is a WebDAV server for user me with a password of its own,
// keeping files in memory, and every password it was sent.
type davServer struct {
mu sync.Mutex
pass string
files map[string][]byte
sent []string
url string
}
func newDAVServer(t *testing.T, pass string) *davServer {
t.Helper()
d := &davServer{pass: pass, files: map[string][]byte{}}
srv := httptest.NewServer(d)
t.Cleanup(srv.Close)
d.url = srv.URL + "/dav/"
return d
}
func (d *davServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
d.mu.Lock()
defer d.mu.Unlock()
u, p, ok := r.BasicAuth()
if ok {
d.sent = append(d.sent, p)
}
if !ok || u != "me" || p != d.pass {
w.WriteHeader(http.StatusUnauthorized)
return
}
switch r.Method {
case http.MethodGet:
b, ok := d.files[r.URL.Path]
if !ok {
w.WriteHeader(http.StatusNotFound)
return
}
w.Write(b)
case http.MethodPut:
d.files[r.URL.Path], _ = io.ReadAll(r.Body)
w.WriteHeader(http.StatusCreated)
case "MKCOL":
w.WriteHeader(http.StatusCreated)
default:
w.WriteHeader(http.StatusMethodNotAllowed)
}
}
func (d *davServer) file() []byte {
d.mu.Lock()
defer d.mu.Unlock()
return d.files["/dav/magpie/magpie.magpie-backup"]
}
func (d *davServer) passwords() []string {
d.mu.Lock()
defer d.mu.Unlock()
return slices.Clone(d.sent)
}
// piped is what stdin holds for the secrets asked, a line each: a pipe, so
// they are read as a script's are, never from the terminal the test is in.
func piped(t *testing.T, lines ...string) {
t.Helper()
r, w, err := os.Pipe()
if err != nil {
t.Fatal(err)
}
if len(lines) > 0 {
w.WriteString(strings.Join(lines, "\n") + "\n")
}
w.Close()
oldFile, oldReader := os.Stdin, stdin
os.Stdin, stdin = r, bufio.NewReader(r)
t.Cleanup(func() {
os.Stdin, stdin = oldFile, oldReader
r.Close()
})
}
func TestWebdavCmd(t *testing.T) {
webdavHome(t)
first := newDAVServer(t, "pw")
provider.Save(provider.Provider{ID: "deepseek", Name: "DeepSeek", Chat: "https://api.deepseek.com/v1", Key: "k1"})
// off: nothing to change or sync
if err := webdavCmd([]string{"set", "agents=no"}); err == nil || !strings.Contains(err.Error(), "is off") {
t.Fatalf("set while off: %v", err)
}
if err := webdavCmd([]string{"now"}); err == nil || !strings.Contains(err.Error(), "is off") {
t.Fatalf("now while off: %v", err)
}
if err := webdavCmd(nil); err != nil {
t.Fatal(err)
}
// a wrong address is said before any secret is asked for
if err := webdavCmd([]string{"on", "dav.example.com", "user=me"}); err == nil || !strings.Contains(err.Error(), "not a WebDAV address") {
t.Fatalf("an address with no https://: %v", err)
}
// on: the password and the passphrase asked for, and a sync at once
piped(t, "pw", "correct horse")
if err := webdavCmd([]string{"on", first.url, "user=me", "library=no"}); err != nil {
t.Fatal(err)
}
c, ok := davsync.Load()
if !ok || c.URL != first.url || c.User != "me" || c.Password != "pw" || c.Passphrase != "correct horse" ||
!c.Keys || !c.Agents || c.Library == nil || *c.Library {
t.Fatalf("on: %v %+v", ok, c)
}
if up := first.file(); len(up) == 0 || strings.Contains(string(up), "deepseek") {
t.Fatalf("on the server: %q", up)
}
if v := davsync.Status(); v.Error != "" || v.Last.IsZero() {
t.Fatalf("status: %+v", v)
}
// set: what is given changes, the rest (secrets too) stays
if err := webdavCmd([]string{"set", "agents=no", "keys=no"}); err != nil {
t.Fatal(err)
}
if c, _ := davsync.Load(); c.Agents || c.Keys || c.Password != "pw" || c.Passphrase != "correct horse" || c.URL != first.url {
t.Fatalf("set: %+v", c)
}
// an address with = in it, bare: the same server, so the password stays
if err := webdavCmd([]string{"set", first.url + "?k=v"}); err != nil {
t.Fatal(err)
}
if c, _ := davsync.Load(); c.URL != first.url+"?k=v" || c.Password != "pw" {
t.Fatalf("an address with = in it: %+v", c)
}
for _, bad := range [][]string{{"set", "passphrase=on-the-command-line"}, {"set", "password=on-the-command-line"}, {"set", "keys=maybe"}, {"set", "colour=red"}, {"set", first.url, first.url}} {
if err := webdavCmd(bad); err == nil {
t.Errorf("%v: no error", bad)
}
}
// password= asks for a new one; a wrong one shows at once, and it stays
// on to be put right
piped(t, "nope")
if err := webdavCmd([]string{"set", "password="}); err == nil || !strings.Contains(err.Error(), "401") {
t.Fatalf("wrong password: %v", err)
}
if c, ok := davsync.Load(); !ok || c.Password != "nope" {
t.Fatalf("after a failed sync: %v %+v", ok, c)
}
piped(t, "pw")
if err := webdavCmd([]string{"set", "password="}); err != nil {
t.Fatal(err)
}
// another server: the password saved is not sent there, and one is
// asked for
second := newDAVServer(t, "pw2")
piped(t, "pw2")
if err := webdavCmd([]string{"set", second.url}); err != nil {
t.Fatal(err)
}
if slices.Contains(second.passwords(), "pw") {
t.Fatal("the first server's password went to the second")
}
if c, _ := davsync.Load(); c.URL != second.url || c.Password != "pw2" || c.Passphrase != "correct horse" {
t.Fatalf("moved: %+v", c)
}
// user= alone: no sign-in, nothing asked for, no password sent
sent := len(second.passwords())
if err := webdavCmd([]string{"set", "user="}); err == nil || !strings.Contains(err.Error(), "401") {
t.Fatalf("no sign-in, on a server that asks for one: %v", err)
}
if c, _ := davsync.Load(); c.User != "" || c.Password != "" {
t.Fatalf("user= alone: %+v", c)
}
if n := len(second.passwords()); n != sent {
t.Fatalf("%d passwords sent with no user", n-sent)
}
if err := webdavCmd([]string{"off"}); err != nil {
t.Fatal(err)
}
if _, ok := davsync.Load(); ok {
t.Fatal("still on after off")
}
if len(second.file()) == 0 {
t.Fatal("off took the file off the server")
}
}