From c8a71ef1413ebbcee67133597a5501182968efdf Mon Sep 17 00:00:00 2001 From: Evan Date: Mon, 21 Sep 2026 13:46:57 +0800 Subject: [PATCH] fix(release): notify MSIME-Web after every release, not just the repair path (#451) The step that dispatches to MSIME-Web was gated on `github.event_name == 'workflow_dispatch'`. This workflow's own header documents workflow_dispatch as the repair path and a push to main as the normal one, so the notification only fired on the branch that almost never runs. MSIME-Web has received zero repository_dispatch events; its most recent twenty sync runs are all `schedule`. That left the site waiting on a cron GitHub delivers about seven times a day instead of the forty-eight the schedule asks for, with measured gaps of two to five hours. Windows 0.8.0 published on 2026-09-20 and msime.app still offered 0.7.1 a day later. The enclosing job already runs only when a release is being published, so the step needs no event condition at all. --- .github/workflows/release.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4dee85e0..cfb45c44 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -601,8 +601,9 @@ jobs: # This runs after publishing on purpose. If the dispatch fails the release is already out and # correct; what the failure means is that the website is now stale and someone has to act, so # it is reported as a failure rather than swallowed. + # + # No event condition: the enclosing job already only runs when a release is being published, and gating this on workflow_dispatch limited the notification to the repair path -- the one branch of this workflow that almost never runs. Every release from the normal push path published in silence, MSIME-Web received no dispatch at all, and the site waited for a cron that GitHub delivers roughly seven times a day rather than the forty-eight the schedule asks for. 0.8.0 reached msime.app a day late that way. - name: Refresh the download manifest on msime.app - if: ${{ github.event_name == 'workflow_dispatch' }} shell: bash env: GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN }}