From 28ef33267cea3bdea10a2c49e3686f8496524972 Mon Sep 17 00:00:00 2001 From: aeoform <2790848120@qq.com> Date: Thu, 28 May 2026 23:59:53 +0800 Subject: [PATCH] fix(inject): fail loudly when RPM injection cannot complete exit 0 on rpmrebuild failure produced a broken RPM silently. Use exit 1 and print to stderr so the CI pipeline catches it. Co-Authored-By: Claude Opus 4.7 (1M context) --- openless-all/scripts/inject-fcitx5-plugin.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/openless-all/scripts/inject-fcitx5-plugin.sh b/openless-all/scripts/inject-fcitx5-plugin.sh index 2e971cf8..2b16f5fd 100755 --- a/openless-all/scripts/inject-fcitx5-plugin.sh +++ b/openless-all/scripts/inject-fcitx5-plugin.sh @@ -53,12 +53,12 @@ case "$PKG" in cp "$CONF_SRC" ".$TARGET_CONF" if command -v rpmrebuild &>/dev/null; then rpmrebuild -np -d "$TMPDIR" "$PKG" 2>/dev/null || { - echo "[inject-fcitx5] rpmrebuild failed — rpm injection not available, skipping" - exit 0 + echo "[inject-fcitx5] ERROR: rpmrebuild failed" >&2 + exit 1 } else - echo "[inject-fcitx5] rpmrebuild not found — install it for rpm injection support. Skipping." - exit 0 + echo "[inject-fcitx5] ERROR: rpmrebuild not found — required for RPM injection. Install it with: sudo dnf install rpmrebuild" >&2 + exit 1 fi echo "[inject-fcitx5] Done — rpm updated" ;;