yan9651688
9fc006546c
Admins often recreate groups with the same pricing, routing, and account membership. A server-side duplicate creates an inactive copy for review, preserves eligible account priorities, and recovers ambiguous retries without creating extra groups. Constraint: Group has no neutral JSON metadata field for durable operation recovery Constraint: Model routing references account IDs, so copied configuration requires matching bindings Rejected: Rebuild from the list response | it omits configuration and account priority details Rejected: Store operation identity in business configuration | it would pollute real group settings Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep duplicated groups inactive until an administrator reviews the copied configuration Tested: Go unit and full tests, go vet, integration-tag compile, frontend Vitest, lint, typecheck, production build, and Playwright duplicate flow Not-tested: PostgreSQL container integration locally because Docker is unavailable; CI will execute the database-backed suite
104 lines
3.8 KiB
TypeScript
104 lines
3.8 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const { post } = vi.hoisted(() => ({
|
|
post: vi.fn()
|
|
}))
|
|
|
|
vi.mock('@/api/client', () => ({
|
|
apiClient: { post }
|
|
}))
|
|
|
|
import { duplicate } from '@/api/admin/groups'
|
|
|
|
describe('admin group duplicate API', () => {
|
|
beforeEach(() => {
|
|
localStorage.clear()
|
|
sessionStorage.clear()
|
|
localStorage.setItem('auth_user', JSON.stringify({ id: 7 }))
|
|
post.mockReset()
|
|
post.mockResolvedValue({ data: { id: 43, name: 'primary (Copy)', status: 'inactive' } })
|
|
vi.spyOn(globalThis.crypto, 'randomUUID').mockReturnValue('11111111-1111-4111-8111-111111111111')
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
it('sends a stable idempotency key with the duplicate request', async () => {
|
|
const group = await duplicate(42)
|
|
|
|
expect(post).toHaveBeenCalledWith('/admin/groups/42/duplicate', undefined, {
|
|
headers: {
|
|
'Idempotency-Key': 'group-duplicate-7-42-11111111-1111-4111-8111-111111111111'
|
|
}
|
|
})
|
|
expect(group).toEqual({ id: 43, name: 'primary (Copy)', status: 'inactive' })
|
|
expect(sessionStorage.length).toBe(0)
|
|
})
|
|
|
|
it('reuses the operation key after an ambiguous failed request', async () => {
|
|
post.mockRejectedValueOnce(new Error('network timeout'))
|
|
await expect(duplicate(99)).rejects.toThrow('network timeout')
|
|
|
|
post.mockResolvedValueOnce({ data: { id: 100, name: 'retry (Copy)' } })
|
|
await duplicate(99)
|
|
|
|
expect(post).toHaveBeenCalledTimes(2)
|
|
expect(post.mock.calls[1][2].headers).toEqual(post.mock.calls[0][2].headers)
|
|
expect(sessionStorage.length).toBe(0)
|
|
})
|
|
|
|
it('reuses the operation key after a page reload', async () => {
|
|
post.mockRejectedValueOnce(new Error('network timeout'))
|
|
await expect(duplicate(77)).rejects.toThrow('network timeout')
|
|
const firstHeaders = post.mock.calls[0][2].headers
|
|
|
|
vi.resetModules()
|
|
post.mockResolvedValueOnce({ data: { id: 78, name: 'reload (Copy)' } })
|
|
const { duplicate: duplicateAfterReload } = await import('@/api/admin/groups')
|
|
await duplicateAfterReload(77)
|
|
|
|
expect(post).toHaveBeenCalledTimes(2)
|
|
expect(post.mock.calls[1][2].headers).toEqual(firstHeaders)
|
|
expect(sessionStorage.length).toBe(0)
|
|
})
|
|
|
|
it('does not reuse an operation key across administrators for the same group', async () => {
|
|
post.mockRejectedValueOnce(new Error('first admin timeout'))
|
|
await expect(duplicate(55)).rejects.toThrow('first admin timeout')
|
|
const firstAdminHeaders = post.mock.calls[0][2].headers
|
|
|
|
localStorage.setItem('auth_user', JSON.stringify({ id: 8 }))
|
|
vi.mocked(globalThis.crypto.randomUUID).mockReturnValueOnce(
|
|
'22222222-2222-4222-8222-222222222222'
|
|
)
|
|
post.mockResolvedValueOnce({ data: { id: 56, name: 'second admin copy' } })
|
|
await duplicate(55)
|
|
|
|
expect(post.mock.calls[1][2].headers).not.toEqual(firstAdminHeaders)
|
|
expect(post.mock.calls[1][2].headers).toEqual({
|
|
'Idempotency-Key': 'group-duplicate-8-55-22222222-2222-4222-8222-222222222222'
|
|
})
|
|
expect(sessionStorage.getItem('sub2api:admin:group-duplicate:7:55')).toBe(
|
|
firstAdminHeaders['Idempotency-Key']
|
|
)
|
|
expect(sessionStorage.getItem('sub2api:admin:group-duplicate:8:55')).toBeNull()
|
|
})
|
|
|
|
it('does not persist or reuse keys when the current user cannot be parsed', async () => {
|
|
localStorage.setItem('auth_user', '{invalid json')
|
|
post.mockRejectedValueOnce(new Error('network timeout'))
|
|
await expect(duplicate(66)).rejects.toThrow('network timeout')
|
|
const firstHeaders = post.mock.calls[0][2].headers
|
|
|
|
vi.mocked(globalThis.crypto.randomUUID).mockReturnValueOnce(
|
|
'33333333-3333-4333-8333-333333333333'
|
|
)
|
|
post.mockResolvedValueOnce({ data: { id: 67, name: 'fallback copy' } })
|
|
await duplicate(66)
|
|
|
|
expect(post.mock.calls[1][2].headers).not.toEqual(firstHeaders)
|
|
expect(sessionStorage.length).toBe(0)
|
|
})
|
|
})
|