♻️ Remove unused bool converters
This commit is contained in:
1 parent
70aa122710
commit
eac8f89d54
2 files changed
-106
No files matched your search
@@ -17,7 +17,6 @@ import (
|
||||
"path/filepath"
|
||||
"regexp"
|
||||
"runtime"
|
||||
"strconv"
|
||||
"strings"
|
||||
|
||||
"github.com/spf13/cobra"
|
||||
@@ -86,21 +85,6 @@ func IsJson(s string) bool {
|
||||
return json.Unmarshal([]byte(s), &js) == nil
|
||||
}
|
||||
|
||||
func StrToBoolPtr(b *string) *bool {
|
||||
if b == nil || *b == "" || strings.ToLower(strings.TrimSpace(*b)) == "null" {
|
||||
return nil
|
||||
}
|
||||
return new(*b == "true")
|
||||
}
|
||||
|
||||
func BoolToStrPtr(b *bool) *string {
|
||||
if b == nil {
|
||||
return new("")
|
||||
}
|
||||
|
||||
return new(strconv.FormatBool(*b))
|
||||
}
|
||||
|
||||
func ResetFlags[T any](values map[string]*T, flagSet *pflag.FlagSet) {
|
||||
for name, value := range values {
|
||||
flag := flagSet.Lookup(name)
|
||||
|
||||
@@ -17,58 +17,6 @@ import (
|
||||
"github.com/spf13/pflag"
|
||||
)
|
||||
|
||||
func TestStrToBoolPtr(t *testing.T) {
|
||||
type args struct {
|
||||
b *string
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
args args
|
||||
want *bool
|
||||
}{
|
||||
{
|
||||
name: "true",
|
||||
args: args{b: new("true")},
|
||||
want: func() *bool {
|
||||
b := true
|
||||
return &b
|
||||
}(),
|
||||
},
|
||||
{
|
||||
name: "false",
|
||||
args: args{b: new("false")},
|
||||
want: func() *bool {
|
||||
b := false
|
||||
return &b
|
||||
}(),
|
||||
},
|
||||
{
|
||||
name: "empty",
|
||||
args: args{b: new("")},
|
||||
want: nil,
|
||||
},
|
||||
{
|
||||
name: "null",
|
||||
args: args{b: new("null")},
|
||||
want: nil,
|
||||
},
|
||||
{
|
||||
name: "NULL",
|
||||
args: args{b: new("NULL")},
|
||||
want: nil,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(
|
||||
tt.name, func(t *testing.T) {
|
||||
if got := StrToBoolPtr(tt.args.b); !reflect.DeepEqual(got, tt.want) {
|
||||
t.Errorf("BoolPtr() = %v, want %v", got, tt.want)
|
||||
}
|
||||
},
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGetFileName(t *testing.T) {
|
||||
type args struct {
|
||||
file string
|
||||
@@ -350,44 +298,6 @@ func TestExtractHl(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestBoolToStrPtr(t *testing.T) {
|
||||
bTrue := true
|
||||
bFalse := false
|
||||
type args struct {
|
||||
b *bool
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
args args
|
||||
want *string
|
||||
}{
|
||||
{
|
||||
name: "true",
|
||||
args: args{b: &bTrue},
|
||||
want: new("true"),
|
||||
},
|
||||
{
|
||||
name: "false",
|
||||
args: args{b: &bFalse},
|
||||
want: new("false"),
|
||||
},
|
||||
{
|
||||
name: "nil",
|
||||
args: args{b: nil},
|
||||
want: new(""),
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(
|
||||
tt.name, func(t *testing.T) {
|
||||
if got := BoolToStrPtr(tt.args.b); !reflect.DeepEqual(got, tt.want) {
|
||||
t.Errorf("BoolToStrPtr() = %v, want %v", got, tt.want)
|
||||
}
|
||||
},
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRandomStage(t *testing.T) {
|
||||
s1 := RandomStage()
|
||||
s2 := RandomStage()
|
||||
|
||||
Reference in new issue
Block a user